Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

patron: improve patron detail view #718

Merged
merged 1 commit into from
Oct 13, 2021
Merged

patron: improve patron detail view #718

merged 1 commit into from
Oct 13, 2021

Conversation

zannkukai
Copy link
Contributor

@zannkukai zannkukai commented Oct 8, 2021 •
edited
Loading

  • Improves patron detail view.

Co-authored-by: Renaud Michotte renaud.michotte@gmail.com

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Cypress tests successful?

@zannkukai zannkukai self-assigned this Oct 8, 2021
@github-actions github-actions bot added the f: professional ui Professional interface label Oct 8, 2021
@iGormilhit
Copy link
Contributor

iGormilhit commented Oct 12, 2021 •
edited
Loading

@zannkukai The issue rero/rero-ils#2399 is already closed, as the librarians have reconsidered their demand.

jma
jma approved these changes Oct 12, 2021
View reviewed changes
projects/admin/src/app/scss/styles.scss Outdated Show resolved Hide resolved
iGormilhit
iGormilhit approved these changes Oct 12, 2021
View reviewed changes
Copy link
Contributor

@iGormilhit iGormilhit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit message approved.

@iGormilhit iGormilhit added this to the v1.6.0 milestone Oct 12, 2021
Garfield-fr
Garfield-fr approved these changes Oct 12, 2021
View reviewed changes
projects/admin/src/app/record/detail-view/patron-detail-view/patron-detail-view.component.html Outdated Show resolved Hide resolved
projects/admin/src/app/record/detail-view/patron-detail-view/patron-detail-view.component.html Outdated Show resolved Hide resolved
projects/admin/src/app/record/detail-view/patron-detail-view/patron-detail-view.component.html Outdated Show resolved Hide resolved
projects/admin/src/app/record/detail-view/patron-detail-view/patron-detail-view.component.html Outdated Show resolved Hide resolved
projects/admin/src/app/record/detail-view/patron-detail-view/patron-detail-view.component.html Outdated Show resolved Hide resolved
projects/admin/src/app/record/detail-view/patron-detail-view/patron-detail-view.component.html Outdated Show resolved Hide resolved
projects/admin/src/app/record/detail-view/patron-detail-view/patron-detail-view.component.html Outdated Show resolved Hide resolved
@iGormilhit iGormilhit changed the base branch from dev to staging October 12, 2021 09:13
@zannkukai
patron: improve patron detail view
b616d94 
* Improves patron detail view.

Co-authored-by: Renaud Michotte <renaud.michotte@gmail.com>
@zannkukai zannkukai merged commit d6aecc2 into rero:staging Oct 13, 2021
@zannkukai zannkukai deleted the zan-better-patron-view branch October 13, 2021 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iGormilhit iGormilhit iGormilhit approved these changes

@jma jma jma approved these changes

@Garfield-fr Garfield-fr Garfield-fr approved these changes

Assignees

@zannkukai zannkukai

Labels
f: professional ui Professional interface
Projects
None yet
Milestone
v1.6.0
Development

Successfully merging this pull request may close these issues.
4 participants
@zannkukai @iGormilhit @Garfield-fr @jma