Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

documents: display electronic holdings #734

Merged
merged 1 commit into from
Oct 26, 2021
Merged

documents: display electronic holdings #734

merged 1 commit into from
Oct 26, 2021

Conversation

jma
Copy link
Contributor

@jma jma commented Oct 25, 2021 •
edited
Loading

  • Displays holdings of all types in the document detailed view.
  • Adjust the display to be the same as the public interface.

Co-Authored-by: Johnny Mariéthoz Johnny.Mariethoz@rero.ch

Public view screenshot (for comparison)

image

Admin view screenshot (the new one)

image

Why are you opening this PR?

  • Which task/US does it implement?
  • Which issue does it fix?

Dependencies

My PR depends on rero-ils#<xx>'s PR(s):

  • rero/rero-ils#

How to test?

  • What command should I have to run to test your PR?
  • What should I test through the UI?

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Cypress tests successful?

@jma
documents: display electronic holdings
bef24cf 
* Displays holdings of all types in the document detailed view.
* Adjust the display to be the same as the public interface.

Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
@github-actions github-actions bot added the f: professional ui Professional interface label Oct 25, 2021
@iGormilhit iGormilhit added this to the v1.6.0 milestone Oct 25, 2021
iGormilhit
iGormilhit approved these changes Oct 25, 2021
View reviewed changes
Copy link
Contributor

@iGormilhit iGormilhit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit message approved.

@jma jma merged commit 228c0a7 into rero:staging Oct 26, 2021
lauren-d added a commit to lauren-d/rero-ils-ui that referenced this pull request Oct 28, 2021
@lauren-d
holdings: fixes detail view for electronic serial
ae2dece 
This commit will be deleted when rero#734 is merged.

Co-Authored-by: lauren-d <laurent.dubois@itld-solutions.be>
@jma jma deleted the maj-fix-electronic-holdings branch January 13, 2022 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lauren-d lauren-d lauren-d approved these changes

@benerken benerken benerken approved these changes

@iGormilhit iGormilhit iGormilhit approved these changes

@zannkukai zannkukai Awaiting requested review from zannkukai

Assignees

@jma jma

Labels
f: professional ui Professional interface
Projects
None yet
Milestone
v1.6.0
Development

Successfully merging this pull request may close these issues.
4 participants
@jma @iGormilhit @benerken @lauren-d