circulation: checkin operations when item/patron barcode are identical #776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
f: circulation
Garfield-fr
force-pushed
the
zub-circulation-feature
branch
8 times, most recently
from
107bbac
to
3a1daf0
Compare
A dialog appears when there is an item and a patron with the same barcode. The library chooses the action to execute. * Closes rero/rero-ils#2597. Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Garfield-fr
force-pushed
the
zub-circulation-feature
branch
from
3a1daf0
to
4fe98d6
Compare
benerken
approved these changes
Dec 23, 2021
jma
approved these changes
Dec 23, 2021
| You should have received a copy of the GNU Affero General Public License | ||
| along with this program. If not, see <http://www.gnu.org/licenses/>. | ||
| --> | ||
| <div class="modal show d-block" role="dialog" (window:keypress)="checkinItemOnEnterKey($event)"> |
There was a problem hiding this comment.
d-block seem not required here.
| </div> | ||
| <div class="modal-body"> | ||
| <div class="font-weight-bold" translate> | ||
| One item and one patron were found. |
There was a problem hiding this comment.
Did you check this message with the PO? Can be more explicit.
| }) | ||
| export class CheckinActionComponent { | ||
|
|
||
| /** Checkin action */ |
There was a problem hiding this comment.
In case of patron the action is not a checkin, you can change your comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A dialog appears when there is an item and a patron with the same barcode.
The library chooses the action to execute.
Co-Authored-by: Bertrand Zuchuat bertrand.zuchuat@rero.ch
Code review check list