Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

public-search: complete brief view #8

Merged

Conversation

AoNoOokami
Copy link
Contributor

@AoNoOokami AoNoOokami commented Oct 16, 2019

Why are you opening this PR?

Implements tasks #1061 of US986

  • NEW Adds documents and person filters
  • NEW Adds detailed display of search results

How to test?

cd rero-ils-ui
git fetch rero pull/8/head:PR8
git checkout PR8
npm run build
ng serve public-search

/!\ rero-ils server must be running

Expected results

  • Brief view should look like the screenshot below
  • Filtering with facets should work
  • Clicking on a link should redirect to flask detail view (document title & person name)

Screen Shot 2019-10-16 at 16 27 30

@AoNoOokami AoNoOokami force-pushed the zaa-#1061-public-search-app branch 2 times, most recently from a93c6b1 to fac0c72 Compare October 16, 2019 14:53
@AoNoOokami AoNoOokami added the WIP label Oct 18, 2019
@AoNoOokami AoNoOokami force-pushed the zaa-#1061-public-search-app branch 3 times, most recently from 1dff10f to ff5b082 Compare October 18, 2019 09:50
@AoNoOokami AoNoOokami added WIP and removed WIP labels Oct 18, 2019
@AoNoOokami AoNoOokami force-pushed the zaa-#1061-public-search-app branch 2 times, most recently from 1a22e62 to 9d072f2 Compare October 18, 2019 10:19
@AoNoOokami AoNoOokami removed the WIP label Oct 18, 2019
@AoNoOokami
Copy link
Contributor Author

Rebase done after merge of #7

* Adds documents and person filters
* Adds detailed display of search results

Co-Authored-by: Alicia Zangger <alicia.zangger@rero.ch>
@jma jma merged commit 26d3de9 into rero:US986-admin-homepage Oct 22, 2019
@AoNoOokami AoNoOokami deleted the zaa-#1061-public-search-app branch November 5, 2019 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants