Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

circulation: display due date at checkin #827

Merged
merged 1 commit into from
May 25, 2022
Merged

circulation: display due date at checkin #827

merged 1 commit into from
May 25, 2022

Conversation

vgranata
Copy link
Contributor

@vgranata vgranata commented Mar 29, 2022 •
edited
Loading

Display due date (loans last_end_date) at checkin.

Co-Authored-by: Valeria Granata valeria@chaw.com

Why are you opening this PR?

Solves issue rero/rero-ils#2637

Dependencies

My PR depends on the following rero-ils's PR(s):

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Cypress tests successful?

@github-actions github-actions bot added f: circulation Concerns the circulation interface or backend f: professional ui Professional interface labels Mar 29, 2022
@pronguen
Copy link
Contributor

  • Wrong due date displayed.
    • The due date displayed corresponds to field end_date with loan resource.
    • But this date is updated with the checkin transaction date when doing the checkin, so it will always be "today".

@vgranata
circulation: display due date at checkin
6dac30e 
Co-Authored-by: Valeria Granata <valeria@chaw.com>
@vgranata vgranata force-pushed the grv-2637-circulation-display-due-date branch from f8169b3 to 6dac30e Compare May 11, 2022 09:58
@vgranata vgranata mentioned this pull request May 11, 2022
Merged
7 tasks
@vgranata vgranata merged commit 19994a0 into rero:staging May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Garfield-fr Garfield-fr Garfield-fr approved these changes

@zannkukai zannkukai zannkukai approved these changes

@PascalRepond PascalRepond PascalRepond approved these changes

Assignees
No one assigned
Labels
f: circulation Concerns the circulation interface or backend f: professional ui Professional interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vgranata @pronguen @Garfield-fr @zannkukai @PascalRepond