Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

library: 'at_desk' notification #831

Merged
merged 1 commit into from
May 12, 2022

Conversation

zannkukai
Copy link
Contributor

Edit the library custom form to allow 'at_desk' notification setting.

Co-Authored-by: Renaud Michotte renaud.michotte@gmail.com

dependencies

rero/rero-ils#2810

How to test?

image

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Cypress tests successful?

@zannkukai zannkukai self-assigned this Apr 4, 2022
@github-actions github-actions bot added f: editor Concerns editor based on JSON schema AND custom editor f: professional ui Professional interface labels Apr 4, 2022
@ManaDeweerdt
Copy link
Contributor

ManaDeweerdt commented Apr 22, 2022

@zannkukai zannkukai force-pushed the zan-library-atdesk-notifications branch 2 times, most recently from 62dc53a to 51923c7 Compare May 10, 2022 11:07
Edit the library custom form to allow 'at_desk' notification setting.

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
@zannkukai zannkukai force-pushed the zan-library-atdesk-notifications branch from 51923c7 to 0bbb977 Compare May 12, 2022 11:49
@zannkukai zannkukai merged commit cde962d into rero:staging May 12, 2022
@zannkukai zannkukai deleted the zan-library-atdesk-notifications branch May 12, 2022 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
f: editor Concerns editor based on JSON schema AND custom editor f: professional ui Professional interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants