Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

patron: improve patron profile #833

Merged
merged 1 commit into from
May 9, 2022
Merged

patron: improve patron profile #833

merged 1 commit into from
May 9, 2022

Conversation

zannkukai
Copy link
Contributor

Co-authored-by: Renaud Michotte renaud.michotte@gmail.com

How to test?

image

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Cypress tests successful?

@zannkukai zannkukai self-assigned this Apr 5, 2022
@github-actions github-actions bot added f: circulation Concerns the circulation interface or backend f: public ui Public interface, as opposed to the professional interface f: user management labels Apr 5, 2022
@zannkukai zannkukai force-pushed the zan-fix-issue-2751 branch 2 times, most recently from d91a4bb to ac405e4 Compare April 15, 2022 11:54
@zannkukai
patron: improve patron profile
07683b1 
* Refactoring the public patron profile for a better responsive display.
* Closes rero/rero-ils#2751.

Co-authored-by: Renaud Michotte <renaud.michotte@gmail.com>
@PascalRepond
Copy link
Contributor

PascalRepond commented Apr 29, 2022 •
edited by zannkukai
Loading

PO tests

@zannkukai zannkukai merged commit 56f66cb into rero:staging May 9, 2022
@zannkukai zannkukai deleted the zan-fix-issue-2751 branch May 9, 2022 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PascalRepond PascalRepond PascalRepond approved these changes

@benerken benerken benerken approved these changes

@Garfield-fr Garfield-fr Garfield-fr approved these changes

@vgranata vgranata Awaiting requested review from vgranata

Assignees

@zannkukai zannkukai

Labels
f: circulation Concerns the circulation interface or backend f: public ui Public interface, as opposed to the professional interface f: user management
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Small improvements in the patron account
4 participants
@zannkukai @PascalRepond @Garfield-fr @benerken