Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

holdings: small ui fix #858

Merged
merged 1 commit into from
May 31, 2022
Merged

Conversation

PascalRepond
Copy link
Contributor

@PascalRepond PascalRepond commented May 25, 2022

  • Adds tooltips to buttons in the holding component (admin UI)

Co-Authored-by: Pascal Repond pascal.repond@rero.ch

Why are you opening this PR?

  • Concerns RT 282

@PascalRepond PascalRepond added correction An implemented feature doesn't work as expected UX User experience, ergonomy labels May 25, 2022
@PascalRepond PascalRepond requested a review from vgranata May 25, 2022 09:01
@github-actions github-actions bot added the f: professional ui Professional interface label May 25, 2022
@PascalRepond PascalRepond requested a review from zannkukai May 25, 2022 09:02
@PascalRepond PascalRepond changed the title holdings: ui fixes holdings: small ui fix May 25, 2022
Copy link
Contributor

@zannkukai zannkukai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Igor told me that "holdings" term is always at plural form. Is it true ? if yes, you just need to adapt strings.

@PascalRepond
Copy link
Contributor Author

@zannkukai It's true, but we have to be careful when translating because it is not always plural in other languages.

* Adds tooltips to buttons in the holding component (admin UI)
* Holdings is plural in the UI

Co-Authored-by: Pascal Repond <pascal.repond@rero.ch>
@PascalRepond PascalRepond merged commit 6e55e22 into rero:staging May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
correction An implemented feature doesn't work as expected f: professional ui Professional interface UX User experience, ergonomy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants