documents: open aggregation with filters and add more facets for documents search #867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
f: professional ui
vgranata
force-pushed
the
grv-open-facets
branch
from
f806cc8
to
aa314d4
Compare
vgranata
requested review from
Garfield-fr,
zannkukai,
lauren-d and
jma
and removed request for
lauren-d
zannkukai
requested changes
Jun 20, 2022
| @@ -16,6 +16,7 @@ | |||
| */ | |||
|
|
|||
| import { TestBed } from '@angular/core/testing'; | |||
| import { RouterTestingModule } from '@angular/router/testing'; | |||
There was a problem hiding this comment.
same for this file, all changes could be removed
There was a problem hiding this comment.
I believe these changes are needed because of the changes made in file documents-route.service.ts. The tests fail if I remove these changes.
vgranata
force-pushed
the
grv-open-facets
branch
3 times, most recently
from
f000380
to
ef0a758
Compare
Garfield-fr
reviewed
Jun 27, 2022
| aggregationsBucketSize: 10, | ||
| searchFilters: [ | ||
| { | ||
| label: this._translateService.instant('Online'), |
There was a problem hiding this comment.
Why you don't use label: _('Online') ? (same as line 108)
vgranata
force-pushed
the
grv-open-facets
branch
from
ef0a758
to
1935e34
Compare
* Marks the aggregation as open if the url contains a corresponding filter including children filters. * Adds the ActivatedRoute service for the document route class. Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
vgranata
force-pushed
the
grv-open-facets
branch
2 times, most recently
from
f23d173
to
2988ec2
Compare
zannkukai
approved these changes
Aug 2, 2022
vgranata
force-pushed
the
grv-open-facets
branch
from
2988ec2
to
ecfe663
Compare
Co-Authored-by: Valeria Granata <valeria@chaw.com>
vgranata
force-pushed
the
grv-open-facets
branch
from
ecfe663
to
3abddf4
Compare
PascalRepond
approved these changes
Aug 23, 2022
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-Authored-by: Johnny Mariéthoz Johnny.Mariethoz@rero.ch
Co-Authored-by: Valeria Granata valeria@chaw.com
Why are you opening this PR?
US: rero/rero-ils#2763
Dependencies
My PR depends on
rero-ils#<xx>'s PR(s):Code review check list