Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

menu: add 'switch to public view' entry menu #88

Merged
merged 1 commit into from
Dec 20, 2019
Merged

menu: add 'switch to public view' entry menu #88

merged 1 commit into from
Dec 20, 2019

Conversation

Garfield-fr
Copy link
Contributor

@Garfield-fr Garfield-fr commented Dec 16, 2019 •
edited
Loading

  • Adds entry menu 'switch to public view' to main menu.

Co-Authored-by: Bertrand Zuchuat bertrand.zuchuat@rero.ch

Why are you opening this PR?

  • Adds possibility to switch to public interface.

How to test?

  • Check the new entry before "Menu"

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Extracted translations?

iGormilhit
iGormilhit approved these changes Dec 16, 2019
View reviewed changes
Copy link
Contributor

@iGormilhit iGormilhit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the commit message, I think the title is enough, but as follows: menu: add 'switch to public view' entry menu

projects/admin/src/app/menu/menu.component.ts Outdated Show resolved Hide resolved
@Garfield-fr
menu: add 'switch to public view' entry menu
fd35889 
* Adds entry menu 'switch to public view' to main menu.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
@Garfield-fr
Copy link
Contributor Author

For the commit message, I think the title is enough, but as follows: menu: add 'switch to public view' entry menu

done

@Garfield-fr Garfield-fr changed the title menu: add entry menu switch to public view menu: add 'switch to public view' entry menu Dec 16, 2019
@Garfield-fr Garfield-fr merged commit 347f79c into rero:dev Dec 20, 2019
@Garfield-fr Garfield-fr deleted the zub-switch-public-view branch January 27, 2020 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AoNoOokami AoNoOokami AoNoOokami approved these changes

@zannkukai zannkukai zannkukai approved these changes

@iGormilhit iGormilhit iGormilhit approved these changes

@jma jma Awaiting requested review from jma

@BadrAly BadrAly Awaiting requested review from BadrAly

@benerken benerken Awaiting requested review from benerken

@lauren-d lauren-d Awaiting requested review from lauren-d

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Garfield-fr @iGormilhit @zannkukai @AoNoOokami