Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

document: improve import control #899

Merged
merged 1 commit into from
Oct 4, 2022
Merged

document: improve import control #899

merged 1 commit into from
Oct 4, 2022

Conversation

Garfield-fr
Copy link
Contributor

@Garfield-fr Garfield-fr commented Sep 22, 2022 •
edited
Loading

If no identifier has been selected for the control, we try to search by the main title

Co-Authored-by: Bertrand Zuchuat bertrand.zuchuat@rero.ch

@github-actions github-actions bot added the f: professional ui Professional interface label Sep 22, 2022
@Garfield-fr Garfield-fr self-assigned this Sep 22, 2022
@pronguen pronguen self-requested a review September 27, 2022 15:44
@Garfield-fr Garfield-fr changed the title document: improve check for document import document: improve import control Sep 29, 2022
@Garfield-fr
document: improve import control
a9a01ce 
If no identifier has been selected for the control,
we try to search by the main title

* Closes rero/rero-ils#3031.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
@JoelleDosimont
Copy link

JoelleDosimont commented Oct 3, 2022 •
edited by Garfield-fr
Loading

@Garfield-fr Garfield-fr merged commit 3d67f92 into rero:staging Oct 4, 2022
@Garfield-fr Garfield-fr deleted the zub-import-suggest branch October 5, 2022 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benerken benerken benerken approved these changes

@zannkukai zannkukai zannkukai approved these changes

@pronguen pronguen Awaiting requested review from pronguen

@jma jma Awaiting requested review from jma

@PascalRepond PascalRepond Awaiting requested review from PascalRepond

Assignees

@Garfield-fr Garfield-fr

Labels
f: professional ui Professional interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Import duplicate check suggesting erroneous duplicates
6 participants
@Garfield-fr @JoelleDosimont @pronguen @zannkukai @benerken @PascalRepond