Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix tests #9

Merged
merged 3 commits into from
Oct 17, 2019
Merged

fix tests #9

merged 3 commits into from
Oct 17, 2019

Conversation

jma
Copy link
Contributor

@jma jma commented Oct 16, 2019

admin records: backport briev views and editor

  • Adds the brief views for all the resources.
  • Configures the menu.
  • Adds routes for the record resources.
  • Backports the library and circulation policies editors.
  • Fixes lint for all the backport components.

admin layout: implement layout and tools

  • Adds a footer.
  • Adds a new menu component for navigation.
  • Adds a front page.
  • Adds a user service to retrieve the logged user informations.
  • Updates the app-config service to retrieve the backend settings.

Co-Authored-by: Johnny Mariéthoz Johnny.Mariethoz@rero.ch
Co-Authored-by: Bertrand Zuchuat bertrand.zuchuat@rero.ch

Note: this PR does not pass the tests, I suspect that it is related to npm link and needs also some additional job for the custom editors. Moreover, it contains multiple commits, thus please check the commits individually.

To Test

  • clone this project run npm i
  • run npm run start-proxy and check the interface
  • run ./run-tests.sh

Garfield-fr and others added 3 commits October 16, 2019 08:39
* Adds a footer.
* Adds a new menu component for navigation.
* Adds a front page.
* Adds a user service to retrieve the logged user informations.
* Updates the app-config service to retrieve the backend settings.

Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
* Adds the brief views for all the resources.
* Configures the menu.
* Adds routes for the record resources.
* Backports the library and circulation policies editors.
* Fixes lint for all the backport components.

Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Co-Authored-by: Sébastien Délèze <sebastien.deleze@rero.ch>
@Garfield-fr Garfield-fr merged commit e7203d2 into rero:US986-admin-homepage Oct 17, 2019
@jma jma deleted the maj-admin-records branch December 11, 2019 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants