Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

document: open electronicLocator in new tab #909

Merged
merged 1 commit into from
Nov 16, 2022
Merged

document: open electronicLocator in new tab #909

merged 1 commit into from
Nov 16, 2022

Conversation

PascalRepond
Copy link
Contributor

@PascalRepond PascalRepond commented Nov 10, 2022 •
edited
Loading

  • Addresses RT 428.

Co-Authored-by: Pascal Repond pascal.repond@rero.ch

Why are you opening this PR?

  • Which task/US does it implement?
  • Which issue does it fix?

Dependencies

Linked to rero/rero-ils#3157

How to test?

  • What command should I have to run to test your PR?
  • What should I test through the UI?

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Cypress tests successful?

@PascalRepond
document: open electronicLocator in new tab
5eda6c0 
Co-Authored-by: Pascal Repond <pascal.repond@rero.ch>
@PascalRepond PascalRepond added the correction An implemented feature doesn't work as expected label Nov 10, 2022
@github-actions github-actions bot added the f: professional ui Professional interface label Nov 10, 2022
@PascalRepond PascalRepond mentioned this pull request Nov 10, 2022
Merged
@PascalRepond PascalRepond requested review from jma and removed request for Garfield-fr November 14, 2022 06:51
@PascalRepond PascalRepond merged commit cdb3291 into rero:staging Nov 16, 2022
@PascalRepond PascalRepond deleted the rep-eloc branch November 16, 2022 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zannkukai zannkukai zannkukai approved these changes

@jma jma Awaiting requested review from jma

Assignees
No one assigned
Labels
correction An implemented feature doesn't work as expected f: professional ui Professional interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PascalRepond @zannkukai