Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

circulation: fix manual fee modal dialog #940

Merged
merged 1 commit into from
Feb 20, 2023
Merged

circulation: fix manual fee modal dialog #940

merged 1 commit into from
Feb 20, 2023

Conversation

zannkukai
Copy link
Contributor

Fix subscription to modal dialog box when adding a manual fee to prevent unknown component subscription.

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Cypress tests successful?

@zannkukai zannkukai self-assigned this Feb 20, 2023
@github-actions github-actions bot added f: circulation Concerns the circulation interface or backend f: editor Concerns editor based on JSON schema AND custom editor f: professional ui Professional interface f: user management labels Feb 20, 2023
@zannkukai
circulation: fix manual fee modal dialog
5b01d7e 
Fix subscription to modal dialog box when adding a manual fee to prevent
unknown component subscription.

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
@github-actions github-actions bot removed the f: editor Concerns editor based on JSON schema AND custom editor label Feb 20, 2023
@zannkukai zannkukai merged commit 049a7e4 into rero:staging Feb 20, 2023
@zannkukai zannkukai deleted the zan-fix-manual-fee-modal branch February 20, 2023 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ManaDeweerdt ManaDeweerdt ManaDeweerdt approved these changes

@Garfield-fr Garfield-fr Garfield-fr approved these changes

Assignees

@zannkukai zannkukai

Labels
f: circulation Concerns the circulation interface or backend f: professional ui Professional interface f: user management
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zannkukai @Garfield-fr @ManaDeweerdt