Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dependencies: update #960

Merged
merged 1 commit into from
Mar 29, 2023
Merged

dependencies: update #960

merged 1 commit into from
Mar 29, 2023

Conversation

rerowep
Copy link
Contributor

@rerowep rerowep commented Mar 23, 2023

Why are you opening this PR?

  • Which task/US does it implement?
  • Which issue does it fix?

Dependencies

My PR depends on rero-ils#<xx>'s PR(s):

  • rero/rero-ils#

How to test?

  • What command should I have to run to test your PR?
  • What should I test through the UI?

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Cypress tests successful?

@rerowep rerowep self-assigned this Mar 23, 2023
zannkukai
zannkukai approved these changes Mar 27, 2023
View reviewed changes
Copy link
Contributor

@zannkukai zannkukai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Nice. Thx

@rerowep
dependencies: update
e1feada 
Co-Authored-by: Peter Weber <peter.weber@rero.ch>
@rerowep rerowep force-pushed the wep-#2545-dependencies-update branch from b5899b4 to e1feada Compare March 27, 2023 08:51
@rerowep rerowep merged commit 77155d0 into staging Mar 29, 2023
@rerowep rerowep deleted the wep-#2545-dependencies-update branch January 31, 2024 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lauren-d lauren-d lauren-d approved these changes

@benerken benerken benerken approved these changes

@zannkukai zannkukai zannkukai approved these changes

@Garfield-fr Garfield-fr Garfield-fr approved these changes

@jma jma Awaiting requested review from jma

Assignees

@rerowep rerowep

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rerowep @Garfield-fr @zannkukai @benerken @lauren-d