Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

library switch menu: fix sort by name #970

Merged
merged 1 commit into from
Apr 18, 2023
Merged

library switch menu: fix sort by name #970

merged 1 commit into from
Apr 18, 2023

Conversation

Garfield-fr
Copy link
Contributor

@Garfield-fr Garfield-fr self-assigned this Apr 12, 2023
@github-actions github-actions bot added the f: professional ui Professional interface label Apr 12, 2023
@PascalRepond
Copy link
Contributor

This sorts the libraries by library.name, the issue specifies to sort them by library.code.

@Garfield-fr
library switch menu: fix sort by name
d7fc546 
* Closes rero/rero-ils#2397.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
@Garfield-fr
Copy link
Contributor Author

This sorts the libraries by library.name, the issue specifies to sort them by library.code.

My bad. I corrected by sorting on the code.

@Garfield-fr Garfield-fr merged commit 0ace2ea into rero:staging Apr 18, 2023
@Garfield-fr Garfield-fr deleted the zub-library-switch-sort branch October 10, 2023 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PascalRepond PascalRepond PascalRepond approved these changes

@lauren-d lauren-d lauren-d approved these changes

@zannkukai zannkukai zannkukai approved these changes

@jma jma Awaiting requested review from jma

Assignees

@Garfield-fr Garfield-fr

Labels
f: professional ui Professional interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

institutions list should respect alphabetical order
4 participants
@Garfield-fr @PascalRepond @zannkukai @lauren-d