Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

circulation: add cancel request on pending tag #973

Merged
merged 1 commit into from
Apr 18, 2023
Merged

circulation: add cancel request on pending tag #973

merged 1 commit into from
Apr 18, 2023

Conversation

Garfield-fr
Copy link
Contributor

@Garfield-fr Garfield-fr self-assigned this Apr 13, 2023
@github-actions github-actions bot added f: circulation Concerns the circulation interface or backend f: professional ui Professional interface f: user management labels Apr 13, 2023
PascalRepond
PascalRepond requested changes Apr 13, 2023
View reviewed changes
Copy link
Contributor

@PascalRepond PascalRepond left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests

  • The button should also be available for documents that are in the "to pick-up" tab (cf. issue specs)
  • Deleting a request from the patron view or from the item brief view should produce the same alert message template.

@Garfield-fr Garfield-fr force-pushed the zub-circulation-cancel-request branch from c656093 to 016d077 Compare April 13, 2023 10:18
@Garfield-fr Garfield-fr force-pushed the zub-circulation-cancel-request branch from 016d077 to be88b35 Compare April 17, 2023 06:15
@Garfield-fr Garfield-fr force-pushed the zub-circulation-cancel-request branch from be88b35 to 830e796 Compare April 17, 2023 06:31
@Garfield-fr Garfield-fr force-pushed the zub-circulation-cancel-request branch 4 times, most recently from 94c2d7d to 9edeb7d Compare April 17, 2023 09:42
@Garfield-fr
circulation: add cancel request on pending tag
c20d481 
* Closes rero/rero-ils#2998.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
@Garfield-fr Garfield-fr force-pushed the zub-circulation-cancel-request branch from 9edeb7d to c20d481 Compare April 18, 2023 13:38
@Garfield-fr Garfield-fr merged commit bafeee7 into rero:staging Apr 18, 2023
@Garfield-fr Garfield-fr deleted the zub-circulation-cancel-request branch October 10, 2023 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PascalRepond PascalRepond PascalRepond approved these changes

@lauren-d lauren-d lauren-d approved these changes

@benerken benerken benerken approved these changes

@zannkukai zannkukai zannkukai approved these changes

Assignees

@Garfield-fr Garfield-fr

Labels
f: circulation Concerns the circulation interface or backend f: professional ui Professional interface f: user management
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Circulation professional interface: it should be possible to cancel a request from the patron account
5 participants
@Garfield-fr @zannkukai @benerken @lauren-d @PascalRepond