keyboard shortcuts: add inventory list hotkey #992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Addresses RT 555. * Adds dev proxy file to gitignore. Co-Authored-by: Pascal Repond <pascal.repond@rero.ch>
Garfield-fr
reviewed
Jun 5, 2023
| @@ -52,3 +52,6 @@ Thumbs.db | |||
|
|
|||
| # eslint | |||
| .eslintcache | |||
|
|
|||
| # test proxy | |||
| dev.proxy.conf.json | |||
There was a problem hiding this comment.
Why this new file ? Not necessary ?
There was a problem hiding this comment.
For testing the ui with the proxy, it is not absolutely necessary but this way we don't need to recreate a file everytime we need to quick-test something
Garfield-fr
approved these changes
Jun 5, 2023
zannkukai
approved these changes
Jun 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are you opening this PR?
Dependencies
My PR depends on
rero-ils#<xx>'s PR(s):How to test?
Code review check list