Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add claim mechanism for periodical issues #998

Merged
merged 4 commits into from
Jun 16, 2023
Merged

Conversation

PascalRepond
Copy link
Contributor

Why are you opening this PR?

  • Which task/US does it implement?
  • Which issue does it fix?

Dependencies

My PR depends on rero-ils#<xx>'s PR(s):

  • rero/rero-ils#

How to test?

  • What command should I have to run to test your PR?
  • What should I test through the UI?

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Cypress tests successful?

zannkukai and others added 4 commits May 25, 2023 11:27
* Removes references to removed "CLAIMED" issue status.
* Adapts item issues route for new facets : claims_count and claims_date

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
* Refactors `Library` resource editor to allow serial acquisition
  data management.
* Use PrimeNg elements in this editor for coherence.

Co-authored-by: Renaud Michotte <renaud.michotte@gmail.com>
* Refactors the library detail view using accordion due to new data to
  display. Using tabs was not more efficient way due to horizontal
  scrolling  of theses tabs with a new entry.

Co-authored-by: Renaud Michotte <renaud.michotte@gmail.com>
- Adds a module for previewing a message and assigning recipients.
- Adds a manual claim on a issue on the holdings detail view.
- Adds a manual claim on a issue on the item detail view.
- Adds claim informations to the issue.
- Uses the preview module on acquisitions.
- Fixes 'switchItemLocation' cancel button handling problem.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
@github-actions github-actions bot added f: acquisitions Related to the acquisition module f: circulation Concerns the circulation interface or backend f: editor Concerns editor based on JSON schema AND custom editor f: professional ui Professional interface f: search translations labels Jun 16, 2023
@PascalRepond PascalRepond merged commit e563c53 into staging Jun 16, 2023
@PascalRepond PascalRepond deleted the US-2509-claims branch February 28, 2024 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
f: acquisitions Related to the acquisition module f: circulation Concerns the circulation interface or backend f: editor Concerns editor based on JSON schema AND custom editor f: professional ui Professional interface f: search translations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants