transaction: add library for patron transactions

* Adds the library pid in the patron transaction index if the transaction is related to a loan. * Closes #1533. Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
rero · Mar 30, 2021 · 0a67262 · 0a67262
1 parent 0b343bc
commit 0a67262
Show file tree

Hide file tree

Showing 4 changed files with 21 additions and 3 deletions.
diff --git a/rero_ils/modules/patron_transactions/api.py b/rero_ils/modules/patron_transactions/api.py
@@ -203,9 +203,12 @@ def get_last_transaction_by_loan_pid(cls, loan_pid, status=None):
     @property
     def document_pid(self):
         """Return the document pid of the the patron transaction."""
-        loan = self.loan
-        if loan:
-            return loan.document_pid
+        return self.loan.document_pid if self.loan else None
+
+    @property
+    def library_pid(self):
+        """Return the library pid of the the patron transaction."""
+        return self.loan.library_pid if self.loan else None
 
     @property
     def patron_pid(self):

diff --git a/rero_ils/modules/patron_transactions/listener.py b/rero_ils/modules/patron_transactions/listener.py
@@ -38,3 +38,7 @@ def enrich_patron_transaction_data(sender, json=None, record=None, index=None,
                 'pid': record.document_pid,
                 'type': 'documents'
             }
+            json['library'] = {
+                'pid': record.library_pid,
+                'type': 'libraries'
+            }
diff --git a/...odules/patron_transactions/mappings/v7/patron_transactions/patron_transaction-v0.0.1.json b/...odules/patron_transactions/mappings/v7/patron_transactions/patron_transaction-v0.0.1.json
@@ -41,6 +41,16 @@
           }
         }
       },
+      "library": {
+        "properties": {
+          "type": {
+            "type": "keyword"
+          },
+          "pid": {
+            "type": "keyword"
+          }
+        }
+      },
       "loan": {
         "properties": {
           "type": {

diff --git a/tests/api/patron_transactions/test_patron_transactions_rest.py b/tests/api/patron_transactions/test_patron_transactions_rest.py
@@ -107,6 +107,7 @@ def test_patron_transactions_get(client, patron_transaction_overdue_martigny):
     data = get_json(res)
     result = data['hits']['hits'][0]['metadata']
     del(result['document'])
+    del(result['library'])
     assert result == transaction.replace_refs()