Skip to content

Commit

Permalink
assets: move to webpack
Browse files Browse the repository at this point in the history
* Fixes docker file to use a custom rero-ils-ui file.
* Removes npm utils from the bootstrap script.
* Removes angularjs translations extraction.
* Moves all theme related files into a specific directory.
* Removes all bundles files.
* Removes useless INVENIO_SEARCH_UI configuration variables.
* Includes the angular application with a custom manner: it does not
  make sense to use `invenio-assets` for an already optimized bundle.
* Removes js to store the last visited html tab, closes #1394.
* Removes angularjs dependency.
* Use simple code to generate thumbnails in the document detailed view.
* Reduces the docker image size by cleaning several cache files.
* Closes #713.

Signed-off-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
  • Loading branch information
jma committed Dec 3, 2020
1 parent f3275b9 commit 6cee8b0
Show file tree
Hide file tree
Showing 105 changed files with 361 additions and 1,561 deletions.
1 change: 0 additions & 1 deletion Dockerfile.base
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@ RUN pip install --upgrade setuptools wheel pip "poetry<1.1.0"
# Install Node
RUN curl -sL https://deb.nodesource.com/setup_12.x | bash -
RUN apt-get install --no-install-recommends -y nodejs && rm -rf /var/lib/apt/lists/*
RUN npm install --silent node-sass@4.14.1 clean-css-cli@4.3.0 uglify-js@3.9.4 requirejs@2.3.6

# RUN npm update

Expand Down
5 changes: 0 additions & 5 deletions babel.ini
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,6 @@ encoding = utf-8
[python: **/manual_translations.txt]
encoding = utf-8

# Extraction from Angular templates
[angular_gettext: **/static/templates/**/**.html]

# Extraction from Jinja2 templates
[jinja2: **/templates/**.html]
encoding = utf-8
Expand All @@ -32,12 +29,10 @@ silent=false

# Extraction from JavaScript files
[ignore: static/js/rero_ils/admin/**]
[ignore: **/webpack_assets/**/**.js]
[javascript: **.js]
encoding = utf-8
extract_messages = $._, jQuery._

# Extraction from json files (schema, form)
[ignore: **/webpack_assets/**/**.json]
[json: **.json]
keys_to_translate = ['^title$', '^label$', 'description', 'placeholder', 'name', 'add', '403', '.*Message']
2 changes: 1 addition & 1 deletion docs/api.rst
Original file line number Diff line number Diff line change
Expand Up @@ -20,5 +20,5 @@ API Docs
Views
-----

.. automodule:: rero_ils.views
.. automodule:: rero_ils.theme.views
:members:
91 changes: 42 additions & 49 deletions poetry.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,6 @@ redisbeat = "*"
jsonpickle = "*"
ciso8601 = "*"
# TODO: to be removed when the thumbnail will be refactored
angular-gettext-babel= ">=0.1"
invenio-userprofiles = {git = "https://github.com/rero/invenio-userprofiles.git", tag = "reroprofile"}

## Additionnal constraints on python modules
Expand Down
105 changes: 0 additions & 105 deletions rero_ils/bundles.py

This file was deleted.

Loading

0 comments on commit 6cee8b0

Please sign in to comment.