Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Impossible to save the document editor with field "notes" #1036

Closed
pronguen opened this issue Jun 10, 2020 · 0 comments · Fixed by #1062
Closed

Impossible to save the document editor with field "notes" #1036

pronguen opened this issue Jun 10, 2020 · 0 comments · Fixed by #1062
Assignees
@AoNoOokami
Labels
bug (critical) Blocking issue, should be fixed ASAP f: editor Concerns editor based on JSON schema AND custom editor
Milestone
v0.11.0

Comments

@pronguen
Copy link
Contributor

Describe the issue
Sometimes, when adding a field "notes", the document editor cannot be saved anymore.

To Reproduce

  1. Edit an existing document
  2. Add a note (with a note type and a note content)
  3. Save
  4. Edit again the same document
  5. Try to save: it is not possible

Expected behavior
It is possible to save the document.

Software version
ils.test.rero.ch
v0.9.1

  • from which server URL do you come from? ils.test or ilsdev?
  • checks the version on homepage. Do you see the version as 0.5.0 or a hash as 2493ca6?

Screenshots
If applicable, add screenshots to help explain your problem.

Additional context
Add any other context about the problem here.
@pronguen pronguen added bug f: editor Concerns editor based on JSON schema AND custom editor labels Jun 10, 2020
@iGormilhit iGormilhit added this to the v0.11.0 milestone Jun 16, 2020
@iGormilhit iGormilhit added bug (critical) Blocking issue, should be fixed ASAP and removed bug labels Jun 18, 2020
AoNoOokami pushed a commit to AoNoOokami/rero-ils that referenced this issue Jun 22, 2020
document: fix edition with notes
26e129b 
* Removes notes_text from mapping.
* Creates a filter to display notes in detailed view.
* Closes rero#1036.

Co-Authored-by: Alicia Zangger <alicia.zangger@rero.ch>
@AoNoOokami AoNoOokami mentioned this issue Jun 22, 2020
Merged
7 tasks
AoNoOokami pushed a commit to AoNoOokami/rero-ils that referenced this issue Jun 22, 2020
document: fix edition with notes
f35a608 
* Removes notes_text from mapping.
* Creates a filter to display notes in detailed view.
* Closes rero#1036.

Co-Authored-by: Alicia Zangger <alicia.zangger@rero.ch>
@AoNoOokami AoNoOokami self-assigned this Jun 23, 2020
AoNoOokami pushed a commit that referenced this issue Jun 23, 2020
@AoNoOokami
document: fix edition with notes
ad1bd63 
* Removes notes_text from mapping.
* Creates a filter to display notes in detailed view.
* Closes #1036.

Co-Authored-by: Alicia Zangger <alicia.zangger@rero.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AoNoOokami AoNoOokami

Labels
bug (critical) Blocking issue, should be fixed ASAP f: editor Concerns editor based on JSON schema AND custom editor
Projects
None yet
Milestone
v0.11.0
Development

Successfully merging a pull request may close this issue.

document: fix edition with notes AoNoOokami/rero-ils
3 participants
@iGormilhit @pronguen @AoNoOokami