Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modeOfIssuance conversion is sometimes wrong #1243

Closed
pronguen opened this issue Sep 24, 2020 · 5 comments
Closed

modeOfIssuance conversion is sometimes wrong #1243

pronguen opened this issue Sep 24, 2020 · 5 comments
Assignees
Labels
bug Breaks something but is not blocking f: data About data model, importation, transformation, exportation of data, specific for bibliographic data
Milestone

Comments

@pronguen
Copy link
Contributor

Describe the bug
This document in ilspilot has the wrong mode of issuance: https://ilspilot.test.rero.ch/professional/records/documents/detail/782990
According to conversion specifications, it should be: rdami:1002 / set

To Reproduce
Example: https://ilspilot.test.rero.ch/professional/records/documents/detail/782990

Expected behavior
According to conversion specifications, it should be: rdami:1002 / set

Context

  • server: ilspilot.test.rero.ch
  • version: v0.12.0

Impact: The link from the child document is labelled "Revue" instead of "Series" >
image

@pronguen pronguen added f: data About data model, importation, transformation, exportation of data, specific for bibliographic data triage bug Breaks something but is not blocking labels Sep 24, 2020
@pronguen pronguen modified the milestones: v0.13.0, v0.14.0 Oct 13, 2020
@iGormilhit iGormilhit modified the milestones: v0.14.0, v0.15.0 Nov 18, 2020
@iGormilhit iGormilhit modified the milestones: v0.15.0, v0.14.1 Nov 18, 2020
@iGormilhit iGormilhit removed the triage label Nov 18, 2020
@reropag
Copy link
Contributor

reropag commented Nov 18, 2020

It is not a conversion problem. The problem is related to an error in the incoming record data used to build the pilot database.
The record has been corrected into Virtua since. So this issue can be closed.

@reropag reropag closed this as completed Nov 18, 2020
@pronguen
Copy link
Contributor Author

@BadrAly This issue has been considered for ilspilot (3rd version)? Because the problem is still present...

@pronguen
Copy link
Contributor Author

pronguen commented Jan 4, 2021

This problem seems to be unsolved in https://ilspilot.test.rero.ch (v 0.14.1).

The series "Folio" (MARC 035 $a 0337698) has a mode of issuance rdami:1003 / periodical. According to spec, it should be rdami:1003 / MonographicSeries. In Virtua, the data is set as for MonographicSeries.

We should check if this was corrected for the deployment of https://ilspilot.test.rero.ch (v 0.14.1) or after.

@iGormilhit
Copy link

@pronguen As discussed with @BadrAly this issue is related with incompatibilites between serials holdings that cannot be attached to monographic document, a situation that exists in Virtual. We need to understand how to resolve this situation in RERO ILS.

For now, in order to be able to import Virtua data into RERO ILS, the document type is intentionally changed before importing.

@pronguen
Copy link
Contributor Author

This issue is solved. Concerning the holdings according to document types, see #1612.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Breaks something but is not blocking f: data About data model, importation, transformation, exportation of data, specific for bibliographic data
Projects
None yet
Development

No branches or pull requests

3 participants