Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Serial holdings should be allowed on any document types #1612

Closed
pronguen opened this issue Jan 18, 2021 · 0 comments · Fixed by #1478
Closed

Serial holdings should be allowed on any document types #1612

pronguen opened this issue Jan 18, 2021 · 0 comments · Fixed by #1478
Assignees
@Garfield-fr @BadrAly
Labels
enhancement Improvement of an existing feature f: data About data model, importation, transformation, exportation of data, specific for bibliographic data p-High High priority (to be solved in the 2-3 next months)
Milestone
v1.0.0

Comments

@pronguen
Copy link
Contributor

pronguen commented Jan 18, 2021 •
edited
Loading

How it works

Currently, serial holdings can only be added to document of type "Journal". This is a problem for the editorial collections, comics series, etc., that have holdings rather than items.

Improvement suggestion

  • On the document detailed view, I have a button "Add holdings"
    • I can choose to add a standard, serial or online type.
  • If I choose "standard", we can imagine having the item editor visually separated in two spaces, one for the holdings, one for the item.
@pronguen pronguen added enhancement Improvement of an existing feature triage f: data About data model, importation, transformation, exportation of data, specific for bibliographic data p-High High priority (to be solved in the 2-3 next months) needs info labels Jan 18, 2021
@pronguen pronguen mentioned this issue Jan 18, 2021
Closed
@iGormilhit iGormilhit added this to the v1.0.0 milestone Jan 18, 2021
@iGormilhit iGormilhit removed the triage label Jan 18, 2021
@iGormilhit iGormilhit modified the milestones: v1.0.0, v1.0.1 Jan 20, 2021
BadrAly pushed a commit to BadrAly/rero-ils that referenced this issue Jan 26, 2021
serials: allow loading of serials on non-journal documents
f1ffaa2 
This commit allows:
* loading of holdings of type `serial` on any type of `document`
* loading of holdings of type `standard` of document of type `journal`
* loading of items of type `standard` on holdings of type `serial`

* Closes rero#1612

Co-Authored-by: Aly Badr <aly.badr@rero.ch>
@BadrAly BadrAly mentioned this issue Jan 26, 2021
Merged
6 tasks
BadrAly pushed a commit to BadrAly/rero-ils that referenced this issue Jan 27, 2021
holdings: attach serials to non-serials documents
9a631ae 
* Allows to:
    * Attach holdings of serial type to any type of document.
    * Attach holdings of standard type to document of type journal.
    * Attach items of standard type to holdings of type serial.
* Closes rero#1612.

Co-Authored-by: Aly Badr <aly.badr@rero.ch>
BadrAly pushed a commit to BadrAly/rero-ils that referenced this issue Jan 27, 2021
holdings: attach serials to non-serials documents
761690c 
* Allows to:
    * Attach holdings of serial type to any type of document.
    * Attach holdings of standard type to document of type journal.
    * Attach items of standard type to holdings of type serial.
* Closes rero#1612.

Co-Authored-by: Aly Badr <aly.badr@rero.ch>
BadrAly pushed a commit that referenced this issue Jan 27, 2021
holdings: attach serials to non-serials documents
0f407f6 
* Allows to:
    * Attach holdings of serial type to any type of document.
    * Attach holdings of standard type to document of type journal.
    * Attach items of standard type to holdings of type serial.
* Closes #1612.

Co-Authored-by: Aly Badr <aly.badr@rero.ch>
rerowep pushed a commit that referenced this issue Jan 27, 2021
@rerowep
holdings: attach serials to non-serials documents
f5095b9 
* Allows to:
    * Attach holdings of serial type to any type of document.
    * Attach holdings of standard type to document of type journal.
    * Attach items of standard type to holdings of type serial.
* Closes #1612.

Co-Authored-by: Aly Badr <aly.badr@rero.ch>
@iGormilhit iGormilhit modified the milestones: v1.0.1, v1.0.0 Jan 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Garfield-fr Garfield-fr

@BadrAly BadrAly

Labels
enhancement Improvement of an existing feature f: data About data model, importation, transformation, exportation of data, specific for bibliographic data p-High High priority (to be solved in the 2-3 next months)
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging a pull request may close this issue.

holdings: attach serials to non-serials documents BadrAly/rero-ils
4 participants
@Garfield-fr @iGormilhit @pronguen @BadrAly