Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Holdings for journals have various problems #1252

Closed
pronguen opened this issue Oct 1, 2020 · 1 comment · Fixed by rero/rero-ils-ui#378
Closed

Holdings for journals have various problems #1252

pronguen opened this issue Oct 1, 2020 · 1 comment · Fixed by rero/rero-ils-ui#378
Labels
bug Breaks something but is not blocking

Comments

@pronguen
Copy link
Contributor

pronguen commented Oct 1, 2020

Describe the bug
Sometimes, the

  • hidden issues cannot be expanded
  • tab "Description" is empty
  • issue reception is not possible (due to holdings import from Virtua with type "standard" instead of "serial")
  • mousehover on the trash does not display any message (same reason than previous point)
  • library is not always displayed in the holdings; there is an empty string before the location

To Reproduce

Expected behavior

  • hidden issues can be expanded
  • tab "Description" is displayed
  • issue reception is possible for serial holdings; the button is not displayed for standard holdings
  • mousehover on the trash always displays a message if the button is disabled
  • the library is always displayed in the holdings, just before the location

Context

  • server: ilspilot.test.rero.ch
  • version: v0.12.0

image
@pronguen pronguen added triage bug Breaks something but is not blocking labels Oct 1, 2020
zannkukai added a commit to zannkukai/rero-ils-ui that referenced this issue Oct 1, 2020
@zannkukai
holding: fix holding display problem.
f55935f 
If a document is a serial or electronic, all linked holdings was force
to be displayed as serial/electronic. This PR fix this problem ; despite
of the document metadata, the holding is display depending of the
holding_type metadata from the holding.

Closes rero/rero-ils#1252

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
@zannkukai zannkukai mentioned this issue Oct 1, 2020
Merged
7 tasks
zannkukai added a commit to zannkukai/rero-ils-ui that referenced this issue Oct 1, 2020
@zannkukai
holding: fix holding display problem.
52876d6 
If a document is a serial or electronic, all linked holdings was force
to be displayed as serial/electronic. This PR fix this problem ; despite
of the document metadata, the holding is display depending of the
holding_type metadata from the holding.

Closes rero/rero-ils#1252

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
@BadrAly
Copy link

BadrAly commented Oct 5, 2020

For the problem: issue reception is not possible (due to holdings import from Virtua with type "standard" instead of "serial"):
This is a data problem will be corrected with the next loading of pilot holdings/items.

zannkukai added a commit to rero/rero-ils-ui that referenced this issue Oct 7, 2020
@zannkukai
holding: fix holding display problem.
949846c 
If a document is a serial or electronic, all linked holdings was force
to be displayed as serial/electronic. This PR fix this problem ; despite
of the document metadata, the holding is display depending of the
holding_type metadata from the holding.

Closes rero/rero-ils#1252

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
@iGormilhit iGormilhit removed the triage label Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Breaks something but is not blocking
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

holding: fix holding display problem. zannkukai/rero-ils-ui
3 participants
@iGormilhit @pronguen @BadrAly