-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
circulation: unable to display a patron account in public view when he has a dispute. #1272
Labels
bug
Breaks something but is not blocking
f: circulation
Concerns the circulation interface or backend
f: public ui
Public interface, as opposed to the professional interface
Comments
benerken
added
f: circulation
Concerns the circulation interface or backend
f: public ui
Public interface, as opposed to the professional interface
triage
bug
Breaks something but is not blocking
labels
Oct 9, 2020
benerken
changed the title
circulation: unable to display a patron account in public view he has a dispute.
circulation: unable to display a patron account in public view when he has a dispute.
Oct 9, 2020
zannkukai
added a commit
to zannkukai/rero-ils
that referenced
this issue
Oct 13, 2020
When a patron has some fees containing at least one 'dispute' event, the server crash because ii tries to convert the amount of dispute (always none) to a decimal number. This PR fix this problem checking if the event to display has a valid 'amount' attribute. This PR also fixes some small HTML problems on the patron profile. Closes rero#1272 Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
6 tasks
zannkukai
added a commit
to zannkukai/rero-ils
that referenced
this issue
Oct 14, 2020
When a patron has some fees containing at least one 'dispute' event, the server crash because ii tries to convert the amount of dispute (always none) to a decimal number. This PR fix this problem checking if the event to display has a valid 'amount' attribute. This PR also fixes some small HTML problems on the patron profile. Closes rero#1272 Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
zannkukai
added a commit
to zannkukai/rero-ils
that referenced
this issue
Oct 14, 2020
When a patron has some fees containing at least one 'dispute' event, the server crash because ii tries to convert the amount of dispute (always none) to a decimal number. This PR fix this problem checking if the event to display has a valid 'amount' attribute. This PR also fixes some small HTML problems on the patron profile. Closes rero#1272 Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
zannkukai
added a commit
to zannkukai/rero-ils
that referenced
this issue
Oct 14, 2020
When a patron has some fees containing at least one 'dispute' event, the server crash because ii tries to convert the amount of dispute (always none) to a decimal number. This PR fix this problem checking if the event to display has a valid 'amount' attribute. This PR also fixes some small HTML problems on the patron profile. Closes rero#1272 Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
jma
pushed a commit
that referenced
this issue
Oct 14, 2020
When a patron has some fees containing at least one 'dispute' event, the server crash because ii tries to convert the amount of dispute (always none) to a decimal number. This PR fix this problem checking if the event to display has a valid 'amount' attribute. This PR also fixes some small HTML problems on the patron profile. Closes #1272 Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Breaks something but is not blocking
f: circulation
Concerns the circulation interface or backend
f: public ui
Public interface, as opposed to the professional interface
Describe the bug
The issue occurs in the public view, when the patron is logged and he wants to access its profile.
If he has a "dispute" transaction in the history of fees, he gets an internal server error on the screen.
The server logs shows this kind of message:
To Reproduce
Expected behavior
A patron with fees (and dispute) should be able to display its profile.
Context
Tell us on what server did you spotted the issue, using with browser.
The text was updated successfully, but these errors were encountered: