Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

circulation: a staff cannot delete a request of an item with the status 'at desk' #1293

Closed
ManaDeweerdt opened this issue Oct 13, 2020 · 0 comments · Fixed by rero/rero-ils-ui#397
Closed

circulation: a staff cannot delete a request of an item with the status 'at desk' #1293

ManaDeweerdt opened this issue Oct 13, 2020 · 0 comments · Fixed by rero/rero-ils-ui#397
Assignees
@AoNoOokami
Labels
bug Breaks something but is not blocking f: circulation Concerns the circulation interface or backend
Milestone
v0.14.0

Comments

@ManaDeweerdt
Copy link
Contributor

ManaDeweerdt commented Oct 13, 2020 •
edited by benerken
Loading

Describe the bug
In the professional interface, the staff cannot delete an item with the status 'at desk'.

To Reproduce
Steps to reproduce the behavior:

  1. Log in as a librarian.
  2. Go to the Requests section and scan a barcode.
  3. Click on the Patron name.
  4. Check the 'to pickup' tab of the patron and click on an item.
  5. On the item detail view, the delete icon says 'item cannot be canceled'.

Expected behavior
A librarian should be able to delete a request of an item which is 'at desk'.
@ManaDeweerdt ManaDeweerdt added bug Breaks something but is not blocking triage labels Oct 13, 2020
@benerken benerken changed the title Cannot delete a request of an item with the status 'at desk' circulation: a staff cannot delete a request of an item with the status 'at desk' Oct 13, 2020
@benerken benerken added the f: circulation Concerns the circulation interface or backend label Oct 13, 2020
@pronguen pronguen added this to the v0.14.0 milestone Oct 13, 2020
@AoNoOokami AoNoOokami self-assigned this Oct 20, 2020
AoNoOokami pushed a commit to AoNoOokami/rero-ils-ui that referenced this issue Oct 20, 2020
request: allow cancellation when item is at desk
6d158ee 
* Updates cancel request permissions.
* Adds method to update the item detailed view after a cancel request.
* Adds a flash message to inform the user about item status.
* Closes rero/rero-ils#1293.

Co-Authored-by: Alicia Zangger <alicia.zangger@rero.ch>
@AoNoOokami AoNoOokami mentioned this issue Oct 20, 2020
Merged
7 tasks
AoNoOokami pushed a commit to AoNoOokami/rero-ils-ui that referenced this issue Oct 20, 2020
request: allow cancellation when item is at desk
0ae3585 
* Updates cancel request permissions.
* Adds method to update the item detailed view after a cancel request.
* Adds a flash message to inform the user about item status.
* Closes rero/rero-ils#1293.

Co-Authored-by: Alicia Zangger <alicia.zangger@rero.ch>
AoNoOokami pushed a commit to AoNoOokami/rero-ils-ui that referenced this issue Oct 26, 2020
request: allow cancellation when item is at desk
fd639a5 
* Updates 'cancel request' permissions to allow the cancellation of an
item 'at desk'.
* Adds a method to update the item detailed view after a cancel request.
* Adds a flash message to inform the user about item status.
* Closes rero/rero-ils#1293.

Co-Authored-by: Alicia Zangger <alicia.zangger@rero.ch>
AoNoOokami pushed a commit to AoNoOokami/rero-ils-ui that referenced this issue Oct 26, 2020
request: allow cancellation when item is at desk
41b6e59 
* Updates 'cancel request' permissions to allow the cancellation of an
item 'at desk'.
* Adds a method to update the item detailed view after a cancel request.
* Adds a flash message to inform the user about the item status.
* Moves 'cancel' and 'update' logic in the list component for a better
understanding and to clean the code.
* Closes rero/rero-ils#1293.

Co-Authored-by: Alicia Zangger <alicia.zangger@rero.ch>
AoNoOokami pushed a commit to AoNoOokami/rero-ils-ui that referenced this issue Oct 26, 2020
request: allow cancellation when item is at desk
ea9db81 
* Updates 'cancel request' permissions to allow the cancellation of an
item 'at desk'.
* Adds a method to update the item detailed view after a cancel request.
* Adds a flash message to inform the user about the item status.
* Moves 'cancel' and 'update' logic from the item-transaction component (list item) to
the item-transactions (list) component for a better understanding and to clean the code.
* Closes rero/rero-ils#1293.

Co-Authored-by: Alicia Zangger <alicia.zangger@rero.ch>
AoNoOokami pushed a commit to AoNoOokami/rero-ils-ui that referenced this issue Nov 3, 2020
request: allow cancellation when item is at desk
9b9a854 
* Updates 'cancel request' permissions to allow the cancellation of an
item 'at desk'.
* Adds a method to update the item detailed view after a cancel request.
* Adds a flash message to inform the user about the item status.
* Moves 'cancel' and 'update' logic from the item-transaction component (list item) to
the item-transactions (list) component for a better understanding and to clean the code.
* Closes rero/rero-ils#1293.

Co-Authored-by: Alicia Zangger <alicia.zangger@rero.ch>
AoNoOokami pushed a commit to AoNoOokami/rero-ils-ui that referenced this issue Nov 4, 2020
request: allow cancellation when item is at desk
d4e583b 
* Updates 'cancel request' permissions to allow the cancellation of an
item 'at desk'.
* Adds a method to update the item detailed view after a cancel request.
* Adds a flash message to inform the user about the item status.
* Moves 'cancel' and 'update' logic from the item-transaction component (list item) to
the item-transactions (list) component for a better understanding and to clean the code.
* Closes rero/rero-ils#1293.

Co-Authored-by: Alicia Zangger <alicia.zangger@rero.ch>
AoNoOokami pushed a commit to AoNoOokami/rero-ils-ui that referenced this issue Nov 4, 2020
request: allow cancellation when item is at desk
e2d0d16 
* Updates 'cancel request' permissions to allow the cancellation of an
item 'at desk'.
* Adds a method to update the item detailed view after a cancel request.
* Adds a flash message to inform the user about the item status.
* Moves 'cancel' and 'update' logic from the item-transaction component (list item) to
the item-transactions (list) component for a better understanding and to clean the code.
* Closes rero/rero-ils#1293.

Co-Authored-by: Alicia Zangger <alicia.zangger@rero.ch>
AoNoOokami pushed a commit to AoNoOokami/rero-ils-ui that referenced this issue Nov 4, 2020
request: allow cancellation when item is at desk
40a8557 
* Updates 'cancel request' permissions to allow the cancellation of an
item 'at desk'.
* Adds a method to update the item detailed view after a cancel request.
* Adds a flash message to inform the user about the item status.
* Moves 'cancel' and 'update' logic from the item-transaction component (list item) to
the item-transactions (list) component for a better understanding and to clean the code.
* Closes rero/rero-ils#1293.

Co-Authored-by: Alicia Zangger <alicia.zangger@rero.ch>
AoNoOokami pushed a commit to AoNoOokami/rero-ils-ui that referenced this issue Nov 4, 2020
request: allow cancellation when item is at desk
b606cac 
* Updates 'cancel request' permissions to allow the cancellation of an
item 'at desk'.
* Adds a method to update the item detailed view after a cancel request.
* Adds a flash message to inform the user about the item status.
* Moves 'cancel' and 'update' logic from the item-transaction component (list item) to
the item-transactions (list) component for a better understanding and to clean the code.
* Closes rero/rero-ils#1293.

Co-Authored-by: Alicia Zangger <alicia.zangger@rero.ch>
AoNoOokami pushed a commit to rero/rero-ils-ui that referenced this issue Nov 4, 2020
@AoNoOokami
request: allow cancellation when item is at desk
5fbd8fb 
* Updates 'cancel request' permissions to allow the cancellation of an
item 'at desk'.
* Adds a method to update the item detailed view after a cancel request.
* Adds a flash message to inform the user about the item status.
* Moves 'cancel' and 'update' logic from the item-transaction component (list item) to
the item-transactions (list) component for a better understanding and to clean the code.
* Closes rero/rero-ils#1293.

Co-Authored-by: Alicia Zangger <alicia.zangger@rero.ch>
@iGormilhit iGormilhit removed the triage label Nov 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AoNoOokami AoNoOokami

Labels
bug Breaks something but is not blocking f: circulation Concerns the circulation interface or backend
Projects
None yet
Milestone
v0.14.0
Development

Successfully merging a pull request may close this issue.

request: allow cancellation when item is at desk AoNoOokami/rero-ils-ui
5 participants
@iGormilhit @pronguen @ManaDeweerdt @benerken @AoNoOokami