Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Item CHECKIN_1_1_2 does not work #1334

Closed
pronguen opened this issue Oct 26, 2020 · 1 comment · Fixed by #1408
Closed

Item CHECKIN_1_1_2 does not work #1334

pronguen opened this issue Oct 26, 2020 · 1 comment · Fixed by #1408
Assignees
@BadrAly
Labels
bug Breaks something but is not blocking f: circulation Concerns the circulation interface or backend

Comments

@pronguen
Copy link
Contributor

pronguen commented Oct 26, 2020 •
edited
Loading

Describe the bug

Checkin of an item on shelf without request in another library does not put the item in transit.
This corresponds to action CHECKIN_1_1_2 in the doc file https://github.com/rero/rero-ils/blob/dev/doc/circulation/actions.md#checkin-form

To Reproduce

  1. Create an item
  2. Switch library
  3. Check in this item
  4. See the strange flash message
  5. See the item status

Expected behavior

Status should be "IN_TRANSIT_TO_HOUSE".
The flash message should be "The item is in transit."
A line with the details should be displayed in the checkin form.

Context

  • server: ils.test.rero.ch
  • version: v0.13.0

Screenshots

image
@pronguen pronguen added f: circulation Concerns the circulation interface or backend triage bug Breaks something but is not blocking labels Oct 26, 2020
@iGormilhit
Copy link

@pronguen Does "CHECKIN_1_1_2" refer to the corresponding action in https://github.com/rero/rero-ils/blob/dev/doc/circulation/actions.md#checkin-form, section 1.i.b?

I'm asking, because I thought that theses actions where automatically tested (unit tests), and should have identified this issue.

Maybe @BadrAly knows something about it.

@iGormilhit iGormilhit removed the triage label Oct 28, 2020
@BadrAly BadrAly self-assigned this Oct 28, 2020
BadrAly pushed a commit to BadrAly/rero-ils that referenced this issue Oct 30, 2020
circulation: checkin an item with no loans
173fbc2 
Fixes bug when checkin an on_shelf or in_transit items
(with no loans) did not receive the correct item status.

* Closes rero#1334

Co-Authored-by: Aly Badr <aly.badr@rero.ch>
@BadrAly BadrAly mentioned this issue Oct 30, 2020
Closed
6 tasks
BadrAly pushed a commit to BadrAly/rero-ils that referenced this issue Oct 30, 2020
circulation: checkin an item with no loans
a189509 
Fixes bug when checkin an on_shelf or in_transit items
(with no loans) did not receive the correct item status.

* Closes rero#1334

Co-Authored-by: Aly Badr <aly.badr@rero.ch>
BadrAly pushed a commit to BadrAly/rero-ils that referenced this issue Nov 4, 2020
circulation: checkin an item with no loans
a5e73be 
Fixes bug when checkin an on_shelf or in_transit items
(with no loans) did not receive the correct item status.

* Closes rero#1334

Co-Authored-by: Aly Badr <aly.badr@rero.ch>
BadrAly pushed a commit to BadrAly/rero-ils that referenced this issue Nov 5, 2020
circulation: checkin an item with no loans
0c28a0c 
Fixes bug when checkin an on_shelf or in_transit items
(with no loans) did not receive the correct item status.

* Closes rero#1334

Co-Authored-by: Aly Badr <aly.badr@rero.ch>
BadrAly pushed a commit to BadrAly/rero-ils that referenced this issue Nov 5, 2020
circulation: checkin an item with no loans
7c7d4e8 
Fixes bug when checkin an on_shelf or in_transit items
(with no loans) did not receive the correct item status.

* Closes rero#1334

Co-Authored-by: Aly Badr <aly.badr@rero.ch>
BadrAly pushed a commit to BadrAly/rero-ils that referenced this issue Nov 5, 2020
circulation: checkin an item with no loans
7a92f8b 
Fixes bug when checkin an on_shelf or in_transit items
(with no loans) did not receive the correct item status.

* Closes rero#1334

Co-Authored-by: Aly Badr <aly.badr@rero.ch>
BadrAly pushed a commit to BadrAly/rero-ils that referenced this issue Nov 6, 2020
circulation: checkin an item with no loans
f582884 
Fixes bug when checkin an on_shelf or in_transit items
(with no loans) did not receive the correct item status.

* Closes rero#1334

Co-Authored-by: Aly Badr <aly.badr@rero.ch>
BadrAly pushed a commit to BadrAly/rero-ils that referenced this issue Nov 6, 2020
circulation: check in an item with no loans
9a9fb30 
Fixes a bug when checking in an on_shelf or in_transit item (with no
loans) that did not receive the correct item status.

* Closes rero#1334

Co-Authored-by: Aly Badr <aly.badr@rero.ch>
@BadrAly BadrAly mentioned this issue Nov 6, 2020
Merged
6 tasks
BadrAly pushed a commit that referenced this issue Nov 6, 2020
circulation: check in an item with no loans
f9a4e2d 
Fixes a bug when checking in an on_shelf or in_transit item (with no
loans) that did not receive the correct item status.

* Closes #1334

Co-Authored-by: Aly Badr <aly.badr@rero.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BadrAly BadrAly

Labels
bug Breaks something but is not blocking f: circulation Concerns the circulation interface or backend
Projects
None yet
Milestone
No milestone
3 participants
@iGormilhit @pronguen @BadrAly