Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A library should have as many pickup locations as wanted #1341

Closed
pronguen opened this issue Oct 29, 2020 · 4 comments
Closed

A library should have as many pickup locations as wanted #1341

pronguen opened this issue Oct 29, 2020 · 4 comments
Assignees
Labels
f: circulation Concerns the circulation interface or backend new feature Suggestion of an entirely new feature p-High High priority (to be solved in the 2-3 next months)
Milestone

Comments

@pronguen
Copy link
Contributor

How it works

Now, only one pickup location is permitted per library.

How it should works

A library should have as many pickup locations as wanted.

Context

Proposed by pilot libraries

@pronguen pronguen added triage f: circulation Concerns the circulation interface or backend labels Oct 29, 2020
@iGormilhit iGormilhit added new feature Suggestion of an entirely new feature effort: important US candidate and removed triage labels Nov 2, 2020
@iGormilhit
Copy link

@pronguen I use feature_request and US candidate because I think that specifications will be needed. Correct me if I'm wrong.

What is the priority level to be set for this issue?

@pronguen
Copy link
Contributor Author

pronguen commented Nov 2, 2020

@pronguen I use feature_request and US candidate because I think that specifications will be needed. Correct me if I'm wrong.

This is to clarify with @BadrAly but I think it could be done quickly.

What is the priority level to be set for this issue?

Depends on the effort, but rather high.

@BadrAly
Copy link

BadrAly commented Nov 2, 2020

I think maximum 2 story points is enough for having multiple pickup_location. The real problem, is that we have now what we call pickup_library, are we going to drop this?

@pronguen
Copy link
Contributor Author

pronguen commented Nov 2, 2020

@BadrAly I thought it was only the editor that blocks 2 pickup locations per library. But the system would work (without transit inside the library though).

It is not the case? Can you specify the changes to be made then?

Is pickup_library not just a user friendly way to call the pickup location, for the public interface?

@pronguen
with the latest implementation of the circulation actions, we coded the backend to work with pickup_library. I will evaluate the work and get back to you

@iGormilhit iGormilhit added p-High High priority (to be solved in the 2-3 next months) pilot libraries labels Nov 4, 2020
@iGormilhit iGormilhit added this to the v1.0.0 milestone Dec 16, 2020
@iGormilhit iGormilhit removed the effort: important US candidate label Dec 16, 2020
BadrAly pushed a commit to BadrAly/rero-ils that referenced this issue Jan 6, 2021
* Closes rero#1341

Co-Authored-by: Aly Badr <aly.badr@rero.ch>
BadrAly pushed a commit to BadrAly/rero-ils that referenced this issue Jan 27, 2021
* Closes rero#1341

Co-Authored-by: Aly Badr <aly.badr@rero.ch>
BadrAly pushed a commit to BadrAly/rero-ils that referenced this issue Feb 1, 2021
* Closes rero#1341

Co-Authored-by: Aly Badr <aly.badr@rero.ch>
Garfield-fr pushed a commit to Garfield-fr/rero-ils that referenced this issue Feb 2, 2021
* Closes rero#1341

Co-Authored-by: Aly Badr <aly.badr@rero.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
f: circulation Concerns the circulation interface or backend new feature Suggestion of an entirely new feature p-High High priority (to be solved in the 2-3 next months)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants