Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In the pro and public patron account, loans are marked as overdue too late. #1389

Closed
pronguen opened this issue Nov 5, 2020 · 0 comments
Closed

In the pro and public patron account, loans are marked as overdue too late. #1389

pronguen opened this issue Nov 5, 2020 · 0 comments
Labels
bug Breaks something but is not blocking f: circulation Concerns the circulation interface or backend p-High High priority (to be solved in the 2-3 next months)
Milestone
v1.2.0

Comments

@pronguen
Copy link
Contributor

pronguen commented Nov 5, 2020 •
edited
Loading

Describe the bug

In the pro and public patron account (ilspilot.test.rero.ch, v0.12.0, 05.11.20), loans are marked as overdue too late. See 1st screenshot.
Update: in v1.0.1 (ils.test.rero.ch, 04.03.21), the overdue badge is not displayed anymore. Effect, some overdue loans with no fees (or fees already paid) are not displayed distinctly. Ok in the public patron account. See 2nd screenshot.

To Reproduce

  1. Create a loan
  2. Wait that it is one day late

Expected behavior

All loans with a due date before the current date have an overdue badge, in the professional patron account.

Context
Server: ilspilot.test.rero.ch, version: v0.12.0
image

Server: ils.test.rero.ch, version: v1.0.1
image
@pronguen pronguen added f: circulation Concerns the circulation interface or backend triage bug Breaks something but is not blocking labels Nov 5, 2020
@iGormilhit iGormilhit added p-Low Low priority and removed triage labels Nov 19, 2020
@pronguen pronguen added p-High High priority (to be solved in the 2-3 next months) and removed p-Low Low priority labels Mar 4, 2021
@pronguen pronguen added this to the v1.3.0 milestone Mar 4, 2021
zannkukai added a commit to zannkukai/rero-ils-ui that referenced this issue Mar 5, 2021
@zannkukai
circulation: fix several problems
51d2903 
* The patron fees total amount in now returned by the circulation
  informations API. Updates code to reflect this change.
* Creates services to communicate with the backend Loan API to get the
  preview overdue linked to a loan.
* Closes rero/rero-ils#1389

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
zannkukai added a commit to zannkukai/rero-ils-ui that referenced this issue Mar 5, 2021
@zannkukai
admin: fix circulation policies detail view.
890861d 
* Fixes some display problems about circulation policies detail view.
* Closes rero/rero-ils#1389

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
@zannkukai zannkukai mentioned this issue Mar 5, 2021
Merged
7 tasks
zannkukai added a commit to zannkukai/rero-ils-ui that referenced this issue Mar 5, 2021
@zannkukai
admin: fix circulation policies detail view.
070d606 
* Fixes some display problems about circulation policies detail view.
* Closes rero/rero-ils#1389

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
zannkukai added a commit to zannkukai/rero-ils-ui that referenced this issue Mar 5, 2021
@zannkukai
admin: fix circulation policies detail view.
9033ba6 
* Fixes some display problems about circulation policies detail view.
* Closes rero/rero-ils#1389

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
zannkukai added a commit to rero/rero-ils-ui that referenced this issue Mar 5, 2021
@zannkukai
admin: fix circulation policies detail view.
ae8aab7 
* Fixes some display problems about circulation policies detail view.
* Closes rero/rero-ils#1389

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Breaks something but is not blocking f: circulation Concerns the circulation interface or backend p-High High priority (to be solved in the 2-3 next months)
Projects
None yet
Milestone
v1.2.0
Development

No branches or pull requests
2 participants
@iGormilhit @pronguen