Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Show more" button displayed wrongly and problematic counter #1400

Closed
pronguen opened this issue Nov 5, 2020 · 4 comments · Fixed by rero/rero-ils-ui#466
Closed

"Show more" button displayed wrongly and problematic counter #1400

pronguen opened this issue Nov 5, 2020 · 4 comments · Fixed by rero/rero-ils-ui#466
Assignees
@zannkukai
Labels
bug Breaks something but is not blocking f: professional ui Professional interface p-Medium Medium priority (to be solved within 1-2 years)
Milestone
v0.15.0

Comments

@pronguen
Copy link
Contributor

pronguen commented Nov 5, 2020

Describe the bug

For documents with many items, like mangas (ex: R005112192), the counter is not displayed correctly and the "Show more" button does not work (professional view).

To Reproduce

  1. Open the document R005112192 in ilspilot.test.rero.ch

Expected behavior

The five first items are displayed (sorted by field enumerationAndChronology). We can click on "Show more" to display other items.
The counter is correct.

Context

  • server: ilspilot.test.rero.ch
  • version: v0.12.0

Proposed by the pilot libraries

Screenshots

image
@pronguen pronguen added f: professional ui Professional interface triage bug Breaks something but is not blocking labels Nov 5, 2020
@zannkukai
Copy link
Contributor

I think it's solved in v0.13.1.

@iGormilhit iGormilhit added p-Medium Medium priority (to be solved within 1-2 years) and removed triage labels Nov 17, 2020
@iGormilhit iGormilhit added this to the v0.15.0 milestone Nov 17, 2020
@iGormilhit
Copy link

To be verified when https://ilspilot.test.rero.ch will be in RERO ILS v0.14.0.

@iGormilhit
Copy link

@zannkukai @pronguen
This is only partially fixed in v0.14.1. Clicking on the show more link works. But the counter doesn't display anything else than the variable.

ksnip_20201210-072419

@zannkukai
Copy link
Contributor

problem with : https://ilspilot.test.rero.ch/professional/records/documents/detail/877565
No problem with : https://ilspilot.test.rero.ch/professional/records/documents/detail/617709

@zannkukai zannkukai self-assigned this Dec 10, 2020
zannkukai added a commit to zannkukai/rero-ils-ui that referenced this issue Dec 10, 2020
@zannkukai
translation: fix show more resources link
e30d823 
When an holding has a lot of related items, the interface display the 5
first ones followed by a "show more" link containing a counter
corresponding to the hidden resources number. This message is now
extracted for translation.

Closes rero/rero-ils#1400

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
@zannkukai zannkukai mentioned this issue Dec 10, 2020
Merged
7 tasks
zannkukai added a commit to zannkukai/rero-ils-ui that referenced this issue Dec 10, 2020
@zannkukai
translation: fix show more resources link
7818a04 
When an holding has a lot of related items, the interface display the 5
first ones followed by a "show more" link containing a counter
corresponding to the hidden resources number. This message is now
extracted for translation.

Closes rero/rero-ils#1400

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
zannkukai added a commit to rero/rero-ils-ui that referenced this issue Dec 11, 2020
@zannkukai
translation: fix show more resources link
14eca4c 
When an holding has a lot of related items, the interface display the 5
first ones followed by a "show more" link containing a counter
corresponding to the hidden resources number. This message is now
extracted for translation.

Closes rero/rero-ils#1400

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zannkukai zannkukai

Labels
bug Breaks something but is not blocking f: professional ui Professional interface p-Medium Medium priority (to be solved within 1-2 years)
Projects
None yet
Milestone
v0.15.0
Development

Successfully merging a pull request may close this issue.

translation: fix show more resources link zannkukai/rero-ils-ui
3 participants
@iGormilhit @pronguen @zannkukai