Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The new acquisition toggle should be disabled by default for issue items #1449

Closed
pronguen opened this issue Nov 17, 2020 · 0 comments · Fixed by rero/rero-ils-ui#444
Closed

The new acquisition toggle should be disabled by default for issue items #1449

pronguen opened this issue Nov 17, 2020 · 0 comments · Fixed by rero/rero-ils-ui#444
Assignees
@zannkukai
Labels
enhancement Improvement of an existing feature f: acquisitions Related to the acquisition module f: serials p-Medium Medium priority (to be solved within 1-2 years)

Comments

@pronguen
Copy link
Contributor

How it works

In the item editor, the new acquisition toggle is enabled by default for all items

Improvement suggestion

It should be disabled for items of type "issue" because they belong to a serial.
@pronguen pronguen added enhancement Improvement of an existing feature pilot libraries labels Nov 17, 2020
@iGormilhit iGormilhit added f: acquisitions Related to the acquisition module f: serials p-Medium Medium priority (to be solved within 1-2 years) and removed triage labels Nov 18, 2020
@zannkukai zannkukai self-assigned this Nov 25, 2020
zannkukai added a commit to zannkukai/rero-ils-ui that referenced this issue Nov 25, 2020
@zannkukai
items: acquisition default date is optional
41f38ac 
For new issue item, the acquisition date should not be set by default to
the current date. This field must be empty (this change automatically
disable the 'new acquisition' toggle in the item editor).

Closes rero/rero-ils#1449

Co-authored-by: Renaud Michotte <renaud.michotte@gmail.com>
@zannkukai zannkukai mentioned this issue Nov 25, 2020
Merged
7 tasks
zannkukai added a commit to zannkukai/rero-ils-ui that referenced this issue Nov 26, 2020
@zannkukai
items: make acquisition default date optional
5268f5a 
For new issue item, the acquisition date should not be set by default to
the current date. This field must be empty (this change automatically
disable the 'new acquisition' toggle in the item editor).

Closes rero/rero-ils#1449

Co-authored-by: Renaud Michotte <renaud.michotte@gmail.com>
zannkukai added a commit to zannkukai/rero-ils-ui that referenced this issue Nov 26, 2020
@zannkukai
items: make acquisition default date optional
31bb4ea 
For new issue item, the acquisition date should not be set by default to
the current date. This field must be empty (this change automatically
disable the 'new acquisition' toggle in the item editor).

Closes rero/rero-ils#1449

Co-authored-by: Renaud Michotte <renaud.michotte@gmail.com>
zannkukai added a commit to rero/rero-ils-ui that referenced this issue Nov 30, 2020
@zannkukai
items: make acquisition default date optional
ef56bfa 
For new issue item, the acquisition date should not be set by default to
the current date. This field must be empty (this change automatically
disable the 'new acquisition' toggle in the item editor).

Closes rero/rero-ils#1449

Co-authored-by: Renaud Michotte <renaud.michotte@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zannkukai zannkukai

Labels
enhancement Improvement of an existing feature f: acquisitions Related to the acquisition module f: serials p-Medium Medium priority (to be solved within 1-2 years)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

items: make acquisition default date optional zannkukai/rero-ils-ui
3 participants
@iGormilhit @pronguen @zannkukai