Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The search of the public interface does not adapt its suggestions to the browser locale #1509

Closed
pronguen opened this issue Nov 26, 2020 · 0 comments · Fixed by rero/rero-ils-ui#481 or #1588
Closed

The search of the public interface does not adapt its suggestions to the browser locale #1509

pronguen opened this issue Nov 26, 2020 · 0 comments · Fixed by rero/rero-ils-ui#481 or #1588
Assignees
@Garfield-fr
Labels
bug Breaks something but is not blocking f: search p-Medium Medium priority (to be solved within 1-2 years)
Milestone
v1.0.0

Comments

@pronguen
Copy link
Contributor

Describe the bug

In the professional interface, the main search autocomplete gives suggestions in German or French according to the interface language. This is not the case in the public interface (see screenshots).

This principle works fine in the author facet and in the various document displays.

To Reproduce

  1. Create a document and link it to the organisation "Suisse. Conseil fédéral"
  2. Look for "conseil fédéral" in the public main search
    • once in German
    • once in French

Expected behavior

In German, suggestion is "Schweiz. Bundesrat".
In French, suggestion is "Suisse. Conseil fédéral".

Context

Screenshots

Public interface

image

Professional interface

image
@pronguen pronguen added triage bug Breaks something but is not blocking p-Medium Medium priority (to be solved within 1-2 years) labels Nov 26, 2020
@Garfield-fr Garfield-fr self-assigned this Nov 26, 2020
@iGormilhit iGormilhit removed the triage label Nov 26, 2020
@iGormilhit iGormilhit added this to the v0.15.0 milestone Nov 26, 2020
@iGormilhit iGormilhit modified the milestones: v0.15.0, v1.0.0 Dec 17, 2020
@iGormilhit iGormilhit changed the title Autocomplete in public interface does not adapt its suggestions Autocomplete in public interface does not adapt its suggestions to the browser locale Dec 17, 2020
Garfield-fr added a commit to Garfield-fr/rero-ils that referenced this issue Jan 5, 2021
@Garfield-fr
search bar: Adapting the content according to the language
112fe9c 
The suggestions in the auto-complete search bar
presents the data according to the current language.

- closes rero#1509

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Garfield-fr added a commit to Garfield-fr/rero-ils-ui that referenced this issue Jan 5, 2021
@Garfield-fr
search bar: add language parameter
5f79140 
The suggestions in the auto-complete search bar
presents the data according to the current language.

- closes rero/rero-ils#1509

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Garfield-fr added a commit to Garfield-fr/rero-ils-ui that referenced this issue Jan 5, 2021
@Garfield-fr
search bar: add language parameter
23e74fe 
The suggestions in the auto-complete search bar
presents the data according to the current language.

- closes rero/rero-ils#1509

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
This was referenced Jan 5, 2021
Merged
Merged
Garfield-fr added a commit to Garfield-fr/rero-ils that referenced this issue Jan 5, 2021
@Garfield-fr
search bar: adapting the content according to the language
e0c8c31 
The suggestions in the auto-complete search bar
presents the data according to the current language.

- closes rero#1509

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Garfield-fr added a commit to Garfield-fr/rero-ils that referenced this issue Jan 6, 2021
@Garfield-fr
search bar: adapting the content according to the language
46e22c1 
The suggestions in the auto-complete search bar
presents the data according to the current language.

- closes rero#1509

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Garfield-fr added a commit to Garfield-fr/rero-ils that referenced this issue Jan 26, 2021
@Garfield-fr
search: adapt suggestions to the locale
c586d57 
- Presents the suggestions as the query is typed to the user defined
  locale.
- Closes rero#1509.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Garfield-fr added a commit to Garfield-fr/rero-ils-ui that referenced this issue Jan 26, 2021
@Garfield-fr
search: adapt the suggestions to the locale
4f4b652 
* Presents the suggestions, as the query is typed, according to the
  locale of the the user.
* Closes rero/rero-ils#1509.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Garfield-fr added a commit to Garfield-fr/rero-ils that referenced this issue Jan 26, 2021
@Garfield-fr
search: adapt suggestions to the locale
a91ba54 
- Presents the suggestions as the query is typed to the user defined
  locale.
- Closes rero#1509.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Garfield-fr added a commit to Garfield-fr/rero-ils-ui that referenced this issue Jan 26, 2021
@Garfield-fr
search: adapt the suggestions to the locale
90e84b4 
* Presents the suggestions, as the query is typed, according to the
  locale of the the user.
* Closes rero/rero-ils#1509.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Garfield-fr added a commit that referenced this issue Jan 26, 2021
@Garfield-fr
search: adapt suggestions to the locale
3eeac5b 
- Presents the suggestions as the query is typed to the user defined
  locale.
- Closes #1509.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Garfield-fr added a commit to rero/rero-ils-ui that referenced this issue Jan 26, 2021
@Garfield-fr
search: adapt the suggestions to the locale
27fb677 
* Presents the suggestions, as the query is typed, according to the
  locale of the the user.
* Closes rero/rero-ils#1509.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
@iGormilhit iGormilhit changed the title Autocomplete in public interface does not adapt its suggestions to the browser locale The search of the public interface does not adapt its suggestions to the browser locale Feb 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Garfield-fr Garfield-fr

Labels
bug Breaks something but is not blocking f: search p-Medium Medium priority (to be solved within 1-2 years)
Projects
None yet
Milestone
v1.0.0
3 participants
@Garfield-fr @iGormilhit @pronguen