Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not expose currency codes to the translation worflow #1519

Closed
iGormilhit opened this issue Nov 30, 2020 · 0 comments · Fixed by #1536
Closed

Do not expose currency codes to the translation worflow #1519

iGormilhit opened this issue Nov 30, 2020 · 0 comments · Fixed by #1536
Labels
f: data About data model, importation, transformation, exportation of data, specific for bibliographic data p-Low Low priority translations Translations

Comments

@iGormilhit
Copy link

How it works

Currency codes are translated in the vendors JSON schema, as the form options with value and labels are used :

https://github.com/rero/rero-ils/blob/dev/rero_ils/modules/vendors/jsonschemas/vendors/vendor-v0.0.1.json#L245

How it should works

Currency codes should not be translated. In the vendors JSON schema, the form options with value and labels should not be used.
@iGormilhit iGormilhit added translations Translations f: data About data model, importation, transformation, exportation of data, specific for bibliographic data triage p-Low Low priority and removed triage labels Nov 30, 2020
Garfield-fr added a commit to Garfield-fr/rero-ils that referenced this issue Dec 2, 2020
@Garfield-fr
vendor: remove form options on currency
cb0fe07 
Do not translate the currency symbols options of a select.

* closes rero#1519

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
@Garfield-fr Garfield-fr mentioned this issue Dec 2, 2020
Merged
7 tasks
Garfield-fr added a commit to Garfield-fr/rero-ils that referenced this issue Dec 2, 2020
@Garfield-fr
vendor: do not translate currencies
e0613a5 
Do not translate the currency symbols options of a select.

* closes rero#1519

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Garfield-fr added a commit to Garfield-fr/rero-ils that referenced this issue Dec 3, 2020
@Garfield-fr
vendors: do not translate currency codes
f2a03a9 
* closes rero#1519

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
zannkukai pushed a commit that referenced this issue Dec 8, 2020
@Garfield-fr @zannkukai
vendors: do not translate currency codes
3f6ae84 
* closes #1519

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
f: data About data model, importation, transformation, exportation of data, specific for bibliographic data p-Low Low priority translations Translations
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

vendors: do not translate currency codes Garfield-fr/rero-ils
1 participant
@iGormilhit