Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary description in the loan JSON schema #1565

Closed
iGormilhit opened this issue Dec 15, 2020 · 0 comments · Fixed by #1590
Closed

Remove unnecessary description in the loan JSON schema #1565

iGormilhit opened this issue Dec 15, 2020 · 0 comments · Fixed by #1590
Assignees
@zannkukai
Labels
f: data About data model, importation, transformation, exportation of data, specific for bibliographic data p-Low Low priority translations Translations
Milestone
v1.0.0

Comments

@iGormilhit
Copy link

How it works

In the loan JSON schema, there is an unecessary description:

rero-ils/rero_ils/modules/loans/jsonschemas/loans/loan-ils-v0.0.1.json

Line 130 in 7eaea12

"description": "If enabled, loan is set to be anonymized.",

The issue is that this string is going to be translated.

How it should works

Remove the unecessary string from the JSON schema.
@iGormilhit iGormilhit added translations Translations f: data About data model, importation, transformation, exportation of data, specific for bibliographic data correction p-Low Low priority labels Dec 15, 2020
@iGormilhit iGormilhit added this to the v1.0.0 milestone Dec 15, 2020
@zannkukai zannkukai self-assigned this Jan 6, 2021
zannkukai added a commit to zannkukai/rero-ils that referenced this issue Jan 6, 2021
@zannkukai
item: automatic barcode generation
6128fe1 
Set the barcode field as not required field. If an item is
created/updated without barcode, the backend will generated a fictive
barcode itself.

Closes rero#1287
Closes rero#1565

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
@zannkukai zannkukai linked a pull request Jan 6, 2021 that will close this issue
items: improve automatic barcode generation #1590
Merged
7 tasks
@zannkukai zannkukai mentioned this issue Jan 6, 2021
Merged
7 tasks
zannkukai added a commit to zannkukai/rero-ils that referenced this issue Jan 6, 2021
@zannkukai
item: automatic barcode generation
137bb43 
Set the barcode field as not required field. If an item is
created/updated without barcode, the backend will generated a fictive
barcode itself.

Closes rero#1287.
Closes rero#1565.

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
zannkukai added a commit to zannkukai/rero-ils that referenced this issue Jan 13, 2021
@zannkukai
items: improve automatic barcode generation
30e059e 
Set the barcode field as optional. If an item is created/updated
without barcode, the backend will generated a fictive barcode itself.

Closes rero#1287.
Closes rero#1565.

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
zannkukai added a commit that referenced this issue Jan 14, 2021
@zannkukai
items: improve automatic barcode generation
18f9248 
Set the barcode field as optional. If an item is created/updated
without barcode, the backend will generated a fictive barcode itself.

Closes #1287.
Closes #1565.

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
zannkukai added a commit that referenced this issue Jan 19, 2021
@zannkukai
items: improve automatic barcode generation
9178e34 
Set the barcode field as optional. If an item is created/updated
without barcode, the backend will generated a fictive barcode itself.

Closes #1287.
Closes #1565.

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
@iGormilhit iGormilhit changed the title Remove unecessary description in the loan JSON schema Remove unnecessary description in the loan JSON schema Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zannkukai zannkukai

Labels
f: data About data model, importation, transformation, exportation of data, specific for bibliographic data p-Low Low priority translations Translations
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging a pull request may close this issue.

items: improve automatic barcode generation zannkukai/rero-ils
2 participants
@iGormilhit @zannkukai