Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Label of the request list on item detailed view should be improved #1599

Closed
pronguen opened this issue Jan 11, 2021 · 0 comments · Fixed by rero/rero-ils-ui#572
Closed

Label of the request list on item detailed view should be improved #1599

pronguen opened this issue Jan 11, 2021 · 0 comments · Fixed by rero/rero-ils-ui#572
Assignees
@zannkukai
Labels
p-Medium Medium priority (to be solved within 1-2 years) wording When text is concerned, label, message, actions…

Comments

@pronguen
Copy link
Contributor

Describe the bug

The label of the request list on the item detailed view (professional interface) is "Request". This is not consistent with the label of the current borrower "Borrowed by". Moreover, there is a confusion in the translations, where it is impossible to distinguish the verb request from the substantive.

To Reproduce

  1. Open the detailed view of an item with a request

Expected behavior

"Request" is renamed in "Requested by".

Context

Screenshots

image
@pronguen pronguen added pilot libraries bug Breaks something but is not blocking wording When text is concerned, label, message, actions… p-Medium Medium priority (to be solved within 1-2 years) labels Jan 11, 2021
@iGormilhit iGormilhit removed the triage label Jan 11, 2021
@iGormilhit iGormilhit added correction and removed bug Breaks something but is not blocking labels Jan 27, 2021
@zannkukai zannkukai self-assigned this Apr 28, 2021
zannkukai added a commit to zannkukai/rero-ils-ui that referenced this issue Apr 28, 2021
@zannkukai
Issues: Fix several issues
8943fb1 
Closes rero/rero-ils#1846.
Closes rero/rero-ils#1812.
Closes rero/rero-ils#1599.

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
@zannkukai zannkukai mentioned this issue Apr 28, 2021
Merged
7 tasks
zannkukai added a commit to zannkukai/rero-ils-ui that referenced this issue Apr 29, 2021
@zannkukai
Issues: Fix several issues
131f1e3 
Closes rero/rero-ils#1846.
Closes rero/rero-ils#1812.
Closes rero/rero-ils#1599.
Closes rero/rero-ils#1821.

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
zannkukai added a commit to zannkukai/rero-ils-ui that referenced this issue Apr 30, 2021
@zannkukai
Issues: Fix several issues
e28881c 
Closes rero/rero-ils#1846.
Closes rero/rero-ils#1812.
Closes rero/rero-ils#1599.
Closes rero/rero-ils#1821.

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
zannkukai added a commit to rero/rero-ils-ui that referenced this issue May 7, 2021
@zannkukai
Issues: Fix several issues
ef3a7c2 
Closes rero/rero-ils#1846.
Closes rero/rero-ils#1812.
Closes rero/rero-ils#1599.
Closes rero/rero-ils#1821.

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zannkukai zannkukai

Labels
p-Medium Medium priority (to be solved within 1-2 years) wording When text is concerned, label, message, actions…
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

documents: display identifiers detail if it exists zannkukai/rero-ils-ui
3 participants
@iGormilhit @pronguen @zannkukai