Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Admin menu entries cannot be translated. #1627

Closed
ManaDeweerdt opened this issue Jan 21, 2021 · 0 comments · Fixed by rero/rero-ils-ui#508
Closed

Admin menu entries cannot be translated. #1627

ManaDeweerdt opened this issue Jan 21, 2021 · 0 comments · Fixed by rero/rero-ils-ui#508
Assignees
@AoNoOokami
Labels
bug Breaks something but is not blocking f: professional ui Professional interface p-Medium Medium priority (to be solved within 1-2 years) translations Translations
Milestone
v1.0.1

Comments

@ManaDeweerdt
Copy link
Contributor

ManaDeweerdt commented Jan 21, 2021 •
edited by iGormilhit
Loading

Describe the bug

The strings from the admin menus are not extracted, so there cannot be translated.
Ex: user services, reporting & monitoring etc.

  • version: v0.15.0

For instance, the entry "Reports & Monitoring" on Weblate: https://hosted.weblate.org/translate/rero_plus/rero-ils-admin/en_US/?checksum=c1b2fdbe1603256c

Expected

The menu entries should be extrated to be translated through Weblate.
@ManaDeweerdt ManaDeweerdt added triage bug Breaks something but is not blocking labels Jan 21, 2021
@iGormilhit iGormilhit added f: professional ui Professional interface translations Translations p-Medium Medium priority (to be solved within 1-2 years) and removed triage labels Jan 21, 2021
@iGormilhit iGormilhit added this to the v1.1.0 milestone Jan 28, 2021
@AoNoOokami AoNoOokami self-assigned this Feb 2, 2021
AoNoOokami pushed a commit to AoNoOokami/rero-ils-ui that referenced this issue Feb 3, 2021
menu: translate menu entries
2cbc3fb 
* Adds missing strings to manual translations.
* Removes some strings from manual translations because they are already
extracted somewhere else in the application.
* Closes rero/rero-ils#1627.

Co-Authored-by: Alicia Zangger <alicia.zangger@rero.ch>
AoNoOokami pushed a commit to AoNoOokami/rero-ils-ui that referenced this issue Feb 3, 2021
menu: translate menu entries
c4f12e9 
* Adds missing strings to manual translations.
* Removes some strings from manual translations because they are already
extracted somewhere else in the application.
* Harmonize the translation of the labels in 'resource'-route files.
* Closes rero/rero-ils#1627.

Co-Authored-by: Alicia Zangger <alicia.zangger@rero.ch>
@AoNoOokami AoNoOokami mentioned this issue Feb 3, 2021
Merged
7 tasks
AoNoOokami pushed a commit to AoNoOokami/rero-ils-ui that referenced this issue Feb 3, 2021
menu: translate menu entries
b5a2a2c 
* Adds missing strings to manual translations.
* Removes some strings from manual translations because they are already
extracted somewhere else in the application.
* Harmonize the translation of the labels in 'resource'-route files.
* Closes rero/rero-ils#1627.

Co-Authored-by: Alicia Zangger <alicia.zangger@rero.ch>
AoNoOokami pushed a commit to AoNoOokami/rero-ils-ui that referenced this issue Feb 3, 2021
menu: translate menu entries
59cf270 
* Adds missing strings to manual translations.
* Removes some strings from manual translations because they are already
extracted somewhere else in the application.
* Harmonize the translation of the labels in 'resource'-route files.
* Closes rero/rero-ils#1627.

Co-Authored-by: Alicia Zangger <alicia.zangger@rero.ch>
AoNoOokami pushed a commit to AoNoOokami/rero-ils-ui that referenced this issue Feb 8, 2021
menu: translate menu entries
ded494d 
* Adds missing strings to manual translations.
* Removes some strings from manual translations because they are already
extracted somewhere else in the application.
* Harmonize the translation of the labels in 'resource'-route files.
* Closes rero/rero-ils#1627.

Co-Authored-by: Alicia Zangger <alicia.zangger@rero.ch>
AoNoOokami pushed a commit to rero/rero-ils-ui that referenced this issue Feb 22, 2021
@AoNoOokami
menu: translate menu entries
4f01300 
* Adds missing strings to manual translations.
* Removes some strings from manual translations because they are already
extracted somewhere else in the application.
* Harmonize the translation of the labels in 'resource'-route files.
* Closes rero/rero-ils#1627.

Co-Authored-by: Alicia Zangger <alicia.zangger@rero.ch>
@iGormilhit iGormilhit modified the milestones: v1.1.0, v1.0.1 Mar 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AoNoOokami AoNoOokami

Labels
bug Breaks something but is not blocking f: professional ui Professional interface p-Medium Medium priority (to be solved within 1-2 years) translations Translations
Projects
None yet
Milestone
v1.0.1
Development

Successfully merging a pull request may close this issue.

menu: translate menu entries AoNoOokami/rero-ils-ui
3 participants
@iGormilhit @ManaDeweerdt @AoNoOokami