Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Holdings of serial type should be displayed on document detailed view of all kind of document type (public interface) #1660

Closed
iGormilhit opened this issue Feb 2, 2021 · 1 comment · Fixed by rero/rero-ils-ui#521
Closed

Holdings of serial type should be displayed on document detailed view of all kind of document type (public interface) #1660

iGormilhit opened this issue Feb 2, 2021 · 1 comment · Fixed by rero/rero-ils-ui#521
Labels
f: public ui Public interface, as opposed to the professional interface p-High High priority (to be solved in the 2-3 next months)
Milestone
v1.0.1

Comments

@iGormilhit
Copy link

How it works

After the holdings refactoring of the document detailed view and the correction allowing to attach a serial holdings to a non journal document, the holdings of serial type are not displayed.

How it should works

Holdings of serial type should always be displayed, either if they are attached to a document of journal type or of a non journal type. On the public interface, if the document is a non journal type, the holdings is not displayed, only the items are. But if the holdings is of serial type, then the holdings should be displayed.

On the professional interface, holdings are always displayed.
@iGormilhit iGormilhit added f: public ui Public interface, as opposed to the professional interface triage p-High High priority (to be solved in the 2-3 next months) labels Feb 2, 2021
@iGormilhit iGormilhit added this to the v1.1.0 milestone Feb 2, 2021
@iGormilhit iGormilhit removed the triage label Feb 2, 2021
@iGormilhit iGormilhit modified the milestones: v1.1.0, v1.0.1 Feb 10, 2021
@zannkukai
Copy link
Contributor

Do you have any URL where this problem is present ? With a fresh setup on localhost, I didn't find any holdings related to a non-periodical document.

@pronguen pronguen modified the milestones: v1.0.1, v1.1.0 Feb 16, 2021
Garfield-fr added a commit to Garfield-fr/rero-ils-ui that referenced this issue Feb 17, 2021
@Garfield-fr
document: improvement of the display get tab
fe1077e 
* Fixes missing translations.
* Removes custom display of book.
* Adds cancel button on request dialog.
* Closes rero/rero-ils#1660.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
@Garfield-fr Garfield-fr mentioned this issue Feb 17, 2021
Merged
7 tasks
Garfield-fr added a commit to Garfield-fr/rero-ils-ui that referenced this issue Feb 17, 2021
@Garfield-fr
document: improvement of the display get tab
409717b 
* Fixes missing translations.
* Removes custom display of book.
* Adds cancel button on request dialog.
* Closes rero/rero-ils#1660.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Garfield-fr added a commit to Garfield-fr/rero-ils-ui that referenced this issue Feb 17, 2021
@Garfield-fr
document: improvement of the display get tab
8c402b6 
* Fixes missing translations.
* Removes custom display of book.
* Adds cancel button on request dialog.
* Closes rero/rero-ils#1660.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Garfield-fr added a commit to Garfield-fr/rero-ils-ui that referenced this issue Feb 17, 2021
@Garfield-fr
document: improvement of the display get tab
2ee34f1 
* Fixes missing translations.
* Removes custom display of book.
* Adds cancel button on request dialog.
* Closes rero/rero-ils#1660.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Garfield-fr added a commit to rero/rero-ils-ui that referenced this issue Feb 17, 2021
@Garfield-fr
document: improvement of the display get tab
97a5b95 
* Fixes missing translations.
* Removes custom display of book.
* Adds cancel button on request dialog.
* Closes rero/rero-ils#1660.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
@iGormilhit iGormilhit modified the milestones: v1.1.0, v1.0.1 Mar 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
f: public ui Public interface, as opposed to the professional interface p-High High priority (to be solved in the 2-3 next months)
Projects
None yet
Milestone
v1.0.1
Development

Successfully merging a pull request may close this issue.

document: improvement of the display get tab Garfield-fr/rero-ils-ui
3 participants
@iGormilhit @pronguen @zannkukai