Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing Online access for bibliographic records with "Uniform Resource Locator" #1722

Closed
JoelleDosimont opened this issue Feb 23, 2021 · 1 comment · Fixed by #1844 or rero/rero-ils-ui#570
Assignees
Labels
bug Breaks something but is not blocking f: data About data model, importation, transformation, exportation of data, specific for bibliographic data f: public ui Public interface, as opposed to the professional interface p-Medium Medium priority (to be solved within 1-2 years)
Milestone

Comments

@JoelleDosimont
Copy link
Contributor

JoelleDosimont commented Feb 23, 2021

Describe the bug
Online access to records with a "Uniform Resource Locator" field does not appear in the public interface.

To Reproduce

  1. Go to the public interface
  2. Find a record with "Uniform resource Locator" (ex. : Lettres d'un François)
  3. Look at the "Get" tabs
  4. See that there is no online holding and the full text link is missing.

Expected behavior

  • The tab "Online access" is removed.
  • The field electronicLocator is displayed in the public and professional interface, document detailed view, on top of the page:
    • an icon "fa-link" is displayed before each link
    • links of type "resource" are always displayed on top of the list
    • Link text: concatenation of type: content. Translations for type:
      • "resource": Online access
      • "versionOfResource": Other online version
      • "relatedResource": Related resource
      • "hiddenUrl": Hidden URL
      • "noInfo": Related resource
    • note is always displayed in parenthesis after the link
    • url is not displayed but used to set the link
    • "hiddenUrl" are only displayed in the professional interface

Examples (orange: type; green: content; red: note):
image

Context

Screenshots
image

@JoelleDosimont JoelleDosimont added triage bug Breaks something but is not blocking labels Feb 23, 2021
@iGormilhit iGormilhit added f: data About data model, importation, transformation, exportation of data, specific for bibliographic data f: public ui Public interface, as opposed to the professional interface p-Medium Medium priority (to be solved within 1-2 years) and removed triage labels Feb 25, 2021
@iGormilhit iGormilhit added this to the v1.3.0 milestone Mar 4, 2021
@pronguen
Copy link
Contributor

pronguen commented Mar 4, 2021

Decision of PO group: display on top of document detailed view, in public and pro interface.

@pronguen pronguen modified the milestones: v1.2.0, v1.3.0 Apr 14, 2021
@Garfield-fr Garfield-fr self-assigned this Apr 21, 2021
Garfield-fr added a commit to Garfield-fr/rero-ils that referenced this issue Apr 21, 2021
* Moves online resources from the "Descriptions" tab to the header.
* Closes rero#1722.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Garfield-fr added a commit to Garfield-fr/rero-ils-ui that referenced this issue Apr 21, 2021
* Adds online resources to the header.
* Closes rero/rero-ils#1722.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Garfield-fr added a commit to Garfield-fr/rero-ils that referenced this issue Apr 22, 2021
* Moves online resources from the "Descriptions" tab to the header.
* Closes rero#1722.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Garfield-fr added a commit to Garfield-fr/rero-ils that referenced this issue Apr 22, 2021
* Moves online resources from the "Descriptions" tab to the header.
* Closes rero#1722.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Garfield-fr added a commit to Garfield-fr/rero-ils-ui that referenced this issue Apr 27, 2021
* Moves online resources from the "Descriptions" tab to the header.
* Closes rero/rero-ils#1722.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Garfield-fr added a commit to Garfield-fr/rero-ils that referenced this issue Jun 2, 2021
* Moves online resources from the "Descriptions" tab to the header.
* Closes rero#1722.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Garfield-fr added a commit to Garfield-fr/rero-ils-ui that referenced this issue Jun 9, 2021
* Moves online resources from the "Descriptions" tab to the header.
* Closes rero/rero-ils#1722.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Garfield-fr added a commit to Garfield-fr/rero-ils-ui that referenced this issue Jun 9, 2021
* Moves online resources from the "Descriptions" tab to the header.
* Closes rero/rero-ils#1722.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Garfield-fr added a commit to rero/rero-ils-ui that referenced this issue Jun 9, 2021
* Moves online resources from the "Descriptions" tab to the header.
* Closes rero/rero-ils#1722.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Garfield-fr added a commit to Garfield-fr/rero-ils that referenced this issue Jun 9, 2021
* Moves online resources from the "Descriptions" tab to the header.
* Closes rero#1722.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Garfield-fr added a commit that referenced this issue Jun 9, 2021
* Moves online resources from the "Descriptions" tab to the header.
* Closes #1722.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Breaks something but is not blocking f: data About data model, importation, transformation, exportation of data, specific for bibliographic data f: public ui Public interface, as opposed to the professional interface p-Medium Medium priority (to be solved within 1-2 years)
Projects
None yet
4 participants