Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed date: closed date with repetition not taken into account #1734

Closed
ManaDeweerdt opened this issue Mar 1, 2021 · 0 comments · Fixed by #1761
Closed

Fixed date: closed date with repetition not taken into account #1734

ManaDeweerdt opened this issue Mar 1, 2021 · 0 comments · Fixed by #1761
Assignees
@zannkukai
Labels
bug Breaks something but is not blocking f: circulation Concerns the circulation interface or backend p-Medium Medium priority (to be solved within 1-2 years)
Milestone
v1.1.0

Comments

@ManaDeweerdt
Copy link
Contributor

ManaDeweerdt commented Mar 1, 2021 •
edited
Loading

Describe the bug

The closed date with repetition from earlier year is not taken into account while a librarian make a fixed date checkout.
The due date will be set to the closed date without message.
Note: The fixed date checkout works for the closed date from current year, with repetition or not. The due date is set correctly to the next open date.

To Reproduce

  1. Go to "My library" and add a annual repetition to a closed date from last year.
  2. Make a fixed date checkout selecting the closed date.
  3. See error

Expected behavior

If a librarian chose a closed date for the checkout, the system should place the due date to the next open date with a message.

Context
@ManaDeweerdt ManaDeweerdt added triage bug Breaks something but is not blocking f: circulation Concerns the circulation interface or backend p-Medium Medium priority (to be solved within 1-2 years) labels Mar 1, 2021
@iGormilhit iGormilhit removed the triage label Mar 1, 2021
@ManaDeweerdt ManaDeweerdt changed the title Fixed date: repetitive closed date not taken into account Fixed date: closed date with repetition not taken into account Mar 1, 2021
zannkukai added a commit to zannkukai/rero-ils that referenced this issue Mar 11, 2021
@zannkukai
library: correct exception dates behavior.
855db79 
Closes rero#1734.

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
@zannkukai zannkukai mentioned this issue Mar 11, 2021
Merged
7 tasks
zannkukai added a commit to zannkukai/rero-ils that referenced this issue Mar 11, 2021
@zannkukai
library: correct exception dates behavior.
1fea251 
Closes rero#1734.

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
@zannkukai zannkukai self-assigned this Mar 11, 2021
zannkukai added a commit to zannkukai/rero-ils that referenced this issue Mar 11, 2021
@zannkukai
library: correct exception dates behavior.
1adad06 
Closes rero#1734.

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
zannkukai added a commit to zannkukai/rero-ils that referenced this issue Mar 11, 2021
@zannkukai
library: correct exception dates behavior.
91c792e 
Closes rero#1734.

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
zannkukai added a commit that referenced this issue Mar 16, 2021
@zannkukai
library: correct exception dates behavior.
660290d 
Closes #1734.

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
@iGormilhit iGormilhit added this to the v1.1.0 milestone Apr 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zannkukai zannkukai

Labels
bug Breaks something but is not blocking f: circulation Concerns the circulation interface or backend p-Medium Medium priority (to be solved within 1-2 years)
Projects
None yet
Milestone
v1.1.0
Development

Successfully merging a pull request may close this issue.

library: correct exception dates behavior. zannkukai/rero-ils
3 participants
@iGormilhit @zannkukai @ManaDeweerdt