Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Place should be required in document field "Provision activity" #1739

Closed
pronguen opened this issue Mar 2, 2021 · 4 comments · Fixed by #1762
Closed

Place should be required in document field "Provision activity" #1739

pronguen opened this issue Mar 2, 2021 · 4 comments · Fixed by #1762
Assignees
Labels
f: data About data model, importation, transformation, exportation of data, specific for bibliographic data p-Medium Medium priority (to be solved within 1-2 years)
Milestone

Comments

@pronguen
Copy link
Contributor

pronguen commented Mar 2, 2021

How it works

Currently, it is not required to enter a country of publication in a document

How it should works

  • If provisionActivity.type="bf:Publication", place is required.
  • Inside of place, country is always required.
@pronguen pronguen added f: data About data model, importation, transformation, exportation of data, specific for bibliographic data triage p-Medium Medium priority (to be solved within 1-2 years) labels Mar 2, 2021
@iGormilhit iGormilhit removed the triage label Mar 4, 2021
@zannkukai zannkukai self-assigned this Mar 10, 2021
@zannkukai
Copy link
Contributor

@pronguen
There are two 'place' field for a provision activity :

  • the first one is a direct child of 'provision_activity' field and contains a select with the country
  • the second one is a child of 'statement' field, itself a child of 'provision' activity. This is a free text (probably for 'city' information ?).

Assuming of you want that the first one is required, this field is only display if a 'statement' exists.
So do you need also that "statement" is required for provisionActivity.type="bf:Publication" and for this statement that a bf:Place is required too ?

@pronguen
Copy link
Contributor Author

@zannkukai It is clearly about the first one (provisionActivity.place): the country must be required if type="bf:Publication".

Assuming of you want that the first one is required, this field is only display if a 'statement' exists.

I don't understand. I am able to enter a provisionActivity with a country but without statement. The country is never displayed (for now).

@zannkukai
Copy link
Contributor

@pronguen OK for me, the PR was already ready for this implementation. It sounds just strange (for me and myself) to have some data (country, start_date) for a provision_activity but theses data are never shown if you don't enter any statement for the same provision_activity.

So you can have

"provisionActivity": [{
    "place": [{
        "country": "be",
        "type": "bf:Place"
    }],
    "startDate": 2001,
    "type": "bf:Publication"
}]

These infirmation never appears nor in pro, nor in public interface.
But if you add a simple statement :

"provisionActivity": [{
    "place": [{
        "country": "be",
        "type": "bf:Place"
    }],
    "startDate": 2001, 
    "type": "bf:Publication"
    "statement": [{
        "label": [{
            "value": "Louvain"
        }],
       "type": "bf:Place"
    }],
}]

You will only see "Publication : Louvain" into GUI interface

@pronguen
Copy link
Contributor Author

pronguen commented Mar 11, 2021

@zannkukai Yes, indeed. This might be improved in the future.

  • startDate is entered only for the facet and sort options, but the date we want to display is entered in the statement.
  • country is entered because it is part of the standard, but it is not of high importance for the user (it could be displayed in the "Description" tab).

These data are hidden also no in our RERO Explore portal, and I think in the majority of the library catalogues.

zannkukai added a commit to zannkukai/rero-ils that referenced this issue Mar 11, 2021
Closes rero#1739

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
zannkukai added a commit that referenced this issue Mar 16, 2021
Closes #1739

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
@iGormilhit iGormilhit added this to the v1.1.0 milestone Apr 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
f: data About data model, importation, transformation, exportation of data, specific for bibliographic data p-Medium Medium priority (to be solved within 1-2 years)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants