-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Place should be required in document field "Provision activity" #1739
Comments
@pronguen
Assuming of you want that the first one is required, this field is only display if a 'statement' exists. |
@zannkukai It is clearly about the first one (
I don't understand. I am able to enter a provisionActivity with a country but without statement. The country is never displayed (for now). |
@pronguen OK for me, the PR was already ready for this implementation. It sounds just strange (for me and myself) to have some data (country, start_date) for a provision_activity but theses data are never shown if you don't enter any statement for the same provision_activity. So you can have "provisionActivity": [{
"place": [{
"country": "be",
"type": "bf:Place"
}],
"startDate": 2001,
"type": "bf:Publication"
}] These infirmation never appears nor in pro, nor in public interface. "provisionActivity": [{
"place": [{
"country": "be",
"type": "bf:Place"
}],
"startDate": 2001,
"type": "bf:Publication"
"statement": [{
"label": [{
"value": "Louvain"
}],
"type": "bf:Place"
}],
}] You will only see "Publication : Louvain" into GUI interface |
@zannkukai Yes, indeed. This might be improved in the future.
These data are hidden also no in our RERO Explore portal, and I think in the majority of the library catalogues. |
Closes rero#1739 Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
Closes #1739 Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
How it works
Currently, it is not required to enter a country of publication in a document
How it should works
provisionActivity.type
="bf:Publication",place
is required.country
is always required.The text was updated successfully, but these errors were encountered: