Notifications and fees don't respect the circulation policy settings

[pronguen]

Describe the bug

In the screenshot 1, a fixed date checkout was made. Due date on 03.03.21. Default policy applies for reminders and fees. The default policy defines due_soon 5 days before due date, and 1st overdue 5 days after due date. In this case, the notifications didn't respect the settings.

In the screenshot 2, the item 10000000995 is borrowed under the circulation policy "Short", defining due_soon 5 days before due date, and 1st overdue 5 days after due date. In this case, the notifications didn't respect the settings:

• due_soon was actually sent 4 day before, instead of 5
• overdue should have been sent on 02.03.21 but wasn't.

To Reproduce

1. Create a loan
2. Check the notification dates

Expected behavior

The settings applied for notifications, fees and renewals, come from the circulation policy corresponding to patron type/item type.

Context

• server: ils.test.rero.ch
• version: v1.0.1

Screenshots

[zannkukai]

@pronguen Date problem seems a problem with UTC date storage. The process is correct but the date stored doesn't take account of the timezone. I will investigate how to solve that problem.

I detect another problem. If you create a loan the 1st april, for a due_date at the same date. No due_soon notification should be send in my opinion. At this time the system create it (because it think that previous notification creation failed and it retry).
Are you agree with this ?

[pronguen]

If you create a loan the 1st april, for a due_date at the same date. No due_soon notification should be send in my opinion.

This depends on the circulation policy. But I agree on this: if the due soon date is smaller or equal to the checkout date, the due soon notification should not be created.