Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keep history settings enabled but not taken into account #1804

Closed
ManaDeweerdt opened this issue Mar 30, 2021 · 0 comments
Closed

Keep history settings enabled but not taken into account #1804

ManaDeweerdt opened this issue Mar 30, 2021 · 0 comments
Labels
bug Breaks something but is not blocking f: circulation Concerns the circulation interface or backend f: user management p-High High priority (to be solved in the 2-3 next months)
Milestone
v1.2.0

Comments

@ManaDeweerdt
Copy link
Contributor

ManaDeweerdt commented Mar 30, 2021 •
edited
Loading

Describe the bug

As a user, even if I change the 'keep history' settings, my loan history is not saved.
In my personal data tab, it still displays 'The loan history is not saved'.
It is the same as a librarian. I can modify the setting for a user but it is not taken into account.
Note: The 'keep history' settings is displayed as enabled in the edition form of the public and the professional interface.

To Reproduce

  1. Log is as a patron.
  2. Go to 'My account'
  3. Modify the personal data.

Or modify the history settings as a librarian and make some loan transactions.

Expected behavior

The user should see a loan history tab.

Context

Screenshots

Personal data tab:
image

Settings enabled:
image
@ManaDeweerdt ManaDeweerdt added f: circulation Concerns the circulation interface or backend triage bug Breaks something but is not blocking p-Medium Medium priority (to be solved within 1-2 years) labels Mar 30, 2021
@pronguen pronguen added p-High High priority (to be solved in the 2-3 next months) RERO+ libraries and removed p-Medium Medium priority (to be solved within 1-2 years) labels Apr 13, 2021
jma added a commit to jma/rero-ils that referenced this issue Apr 29, 2021
@jma @Garfield-fr
users: patron in multiple organisations
ed661a2 
* Replaces the string `current_patron` by `current_librarian` in the
  entire project.
* Adds a new `current_patrons` containing the list of the logged user
  patron accounts.
* Removes useless jinja detailed view configuration and templates.
* Fixes link redirection for the ill request.
* Cleans the patron request Web API.
* Fixes tests and permissions.
* Replaces `current_organisation.pid` by `current_librarian.organsiation_pid.
* Fixes tests and premissions.
* Gets the patron request rank given a patron instead of a barcode.
* Fixes translated string on circulation.
* Hides the profile menu given the right roles.
* Adds organisations information in the User API.
* Closes rero#1837.
* Closes rero#1460.
* Closes rero#1851.
* Closes rero#1804.
* Closes rero#1634.
* Closes rero#1490.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
@jma jma mentioned this issue Apr 29, 2021
Merged
7 tasks
jma added a commit that referenced this issue Apr 29, 2021
@jma @Garfield-fr
users: patron in multiple organisations
9a76655 
* Replaces the string `current_patron` by `current_librarian` in the
  entire project.
* Adds a new `current_patrons` containing the list of the logged user
  patron accounts.
* Removes useless jinja detailed view configuration and templates.
* Fixes link redirection for the ill request.
* Cleans the patron request Web API.
* Fixes tests and permissions.
* Replaces `current_organisation.pid` by `current_librarian.organsiation_pid.
* Fixes tests and premissions.
* Gets the patron request rank given a patron instead of a barcode.
* Fixes translated string on circulation.
* Hides the profile menu given the right roles.
* Adds organisations information in the User API.
* Closes #1837.
* Closes #1460.
* Closes #1851.
* Closes #1804.
* Closes #1634.
* Closes #1490.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
jma added a commit that referenced this issue Apr 29, 2021
@jma @Garfield-fr
users: patron in multiple organisations
fd40ee9 
* Replaces the string `current_patron` by `current_librarian` in the
  entire project.
* Adds a new `current_patrons` containing the list of the logged user
  patron accounts.
* Removes useless jinja detailed view configuration and templates.
* Fixes link redirection for the ill request.
* Cleans the patron request Web API.
* Fixes tests and permissions.
* Replaces `current_organisation.pid` by `current_librarian.organsiation_pid.
* Fixes tests and premissions.
* Gets the patron request rank given a patron instead of a barcode.
* Fixes translated string on circulation.
* Hides the profile menu given the right roles.
* Adds organisations information in the User API.
* Closes #1837.
* Closes #1460.
* Closes #1851.
* Closes #1804.
* Closes #1634.
* Closes #1490.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
jma added a commit that referenced this issue Apr 29, 2021
@Garfield-fr @jma
users: patron in multiple organisations
e2797e4 
* Changed logged user structure.
* Updated users import cli to accept multiple patron on same user.
* Replaces the string `current_patron` by `current_librarian` in the
  entire project.
* Adds a new `current_patrons` containing the list of the logged user
  patron accounts.
* Removes useless jinja detailed view configuration and templates.
* Fixes link redirection for the ill request.
* Cleans the patron request Web API.
* Fixes tests and permissions.
* Replaces `current_organisation.pid` by `current_librarian.organsiation_pid.
* Fixes tests and premissions.
* Gets the patron request rank given a patron instead of a barcode.
* Fixes translated string on circulation.
* Hides the profile menu given the right roles.
* Adds organisations information in the User API.
* Closes #1837.
* Closes #1460.
* Closes #1851.
* Closes #1804.
* Closes #1634.
* Closes #1490.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
@jma jma closed this as completed in 714fed6 Apr 30, 2021
@iGormilhit iGormilhit added this to the v1.2.0 milestone May 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Breaks something but is not blocking f: circulation Concerns the circulation interface or backend f: user management p-High High priority (to be solved in the 2-3 next months)
Projects
None yet
Milestone
v1.2.0
Development

No branches or pull requests
3 participants
@iGormilhit @pronguen @ManaDeweerdt