Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In a holdings, only active predictions should generate expected and late issues. #1807

Closed
pronguen opened this issue Mar 31, 2021 · 2 comments · Fixed by #1865
Closed

In a holdings, only active predictions should generate expected and late issues. #1807

pronguen opened this issue Mar 31, 2021 · 2 comments · Fixed by #1865
Assignees
@zannkukai
Labels
enhancement Improvement of an existing feature f: professional ui Professional interface f: serials p-High High priority (to be solved in the 2-3 next months)
Milestone
v1.3.0

Comments

@pronguen
Copy link
Contributor

pronguen commented Mar 31, 2021 •
edited
Loading

How it works

Currently, every holdings generates expected and late issues, even for a journal that is not received anymore since a long time.

Improvement suggestion

  • Only holdings with acquisition_status=currently_received generate expected and late issues.
  • Field acquisition_status
    • is required, with default value "currently_received".
    • is place just before field "patterns"
@pronguen pronguen added enhancement Improvement of an existing feature f: professional ui Professional interface triage p-High High priority (to be solved in the 2-3 next months) labels Mar 31, 2021
@zannkukai zannkukai self-assigned this Apr 30, 2021
@zannkukai
Copy link
Contributor

zannkukai commented Apr 30, 2021 •
edited
Loading

@pronguen @BadrAly
Am I wrong if i think that the acquisition_status field is required only for serial type holding ?
Seems not really important for the editor (because we manually create only serial holdings) but important for loading and management of standard holdings

@pronguen
Copy link
Contributor Author

pronguen commented May 3, 2021

@zannkukai The field is possible only for serial holdings, but is currently not required.

zannkukai added a commit to zannkukai/rero-ils that referenced this issue May 3, 2021
@zannkukai
issue: fix creation of late issue
0f998ae 
Closes rero#1807.

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
@zannkukai zannkukai mentioned this issue May 3, 2021
Merged
7 tasks
zannkukai added a commit to zannkukai/rero-ils that referenced this issue May 3, 2021
@zannkukai
issue: fix creation of late issue
4c3e9dd 
Closes rero#1807.

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
zannkukai added a commit to zannkukai/rero-ils that referenced this issue May 3, 2021
@zannkukai
issue: fix creation of late issue
62b0fae 
Closes rero#1807.

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
@iGormilhit iGormilhit added this to the v1.3.0 milestone May 4, 2021
zannkukai added a commit that referenced this issue May 4, 2021
@zannkukai
issue: fix creation of late issue
85eca4a 
Closes #1807.

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
zannkukai added a commit that referenced this issue May 7, 2021
@zannkukai
issue: fix creation of late issue
6babacc 
Closes #1807.

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zannkukai zannkukai

Labels
enhancement Improvement of an existing feature f: professional ui Professional interface f: serials p-High High priority (to be solved in the 2-3 next months)
Projects
None yet
Milestone
v1.3.0
Development

Successfully merging a pull request may close this issue.

issue: fix creation of late issue zannkukai/rero-ils
3 participants
@iGormilhit @pronguen @zannkukai