Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Toast message "dispute saved" is not completely translated #1814

Closed
pronguen opened this issue Apr 7, 2021 · 0 comments · Fixed by rero/rero-ils-ui#583
Closed

Toast message "dispute saved" is not completely translated #1814

pronguen opened this issue Apr 7, 2021 · 0 comments · Fixed by rero/rero-ils-ui#583
Assignees
@zannkukai
Labels
bug Breaks something but is not blocking p-Low Low priority translations Translations

Comments

@pronguen
Copy link
Contributor

pronguen commented Apr 7, 2021 •
edited
Loading

Describe the bug

The toast message "dispute saved" is not completely translated. See screenshot below.

To Reproduce

  1. Open a patron account with fees in the professional interface
  2. Put the interface in French
  3. Create a dispute for one of the engaged fees
  4. See message

Expected behavior

It is translated.

Context

Screenshots

Missing translation:
image

In Weblate (corrresponds to file: projects/admin/src/assets/rero-ils-ui/admin/i18n/fr.json, chaîne 629)
image
@pronguen pronguen added translations Translations triage bug Breaks something but is not blocking p-Low Low priority labels Apr 7, 2021
@iGormilhit iGormilhit removed the triage label Apr 27, 2021
zannkukai added a commit to zannkukai/rero-ils-ui that referenced this issue Apr 30, 2021
@zannkukai
Translation: fix string extraction problem
b4b44e6 
* The `marker` funuction (used to mark a string as extractable for
  translation) cannot be used as enum value. Place these values into the
  manual_translation file.
* Fix translation issues.
* Closes rero/rero-ils#1814

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
@zannkukai zannkukai self-assigned this Apr 30, 2021
@zannkukai zannkukai mentioned this issue Apr 30, 2021
Merged
7 tasks
zannkukai added a commit to zannkukai/rero-ils-ui that referenced this issue May 3, 2021
@zannkukai
translations: fix string extraction problem
1a149bc 
* The `marker` function (used to mark a string as extractable for
  translation) cannot be used as enum value. Place these values into the
  manual_translation file.
* Fix translation issues.
* Closes rero/rero-ils#1814.

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
zannkukai added a commit to zannkukai/rero-ils-ui that referenced this issue May 3, 2021
@zannkukai
translations: fix string extraction problem
6d21b43 
* The `marker` function (used to mark a string as extractable for
  translation) cannot be used as enum value. Place these values into the
  manual_translation file.
* Fix translation issues.
* Closes rero/rero-ils#1814.

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
zannkukai added a commit to rero/rero-ils-ui that referenced this issue May 7, 2021
@zannkukai
translations: fix string extraction problem
311f8f4 
* The `marker` function (used to mark a string as extractable for
  translation) cannot be used as enum value. Place these values into the
  manual_translation file.
* Fix translation issues.
* Closes rero/rero-ils#1814.

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zannkukai zannkukai

Labels
bug Breaks something but is not blocking p-Low Low priority translations Translations
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

translations: fix string extraction problem zannkukai/rero-ils-ui
3 participants
@iGormilhit @pronguen @zannkukai