Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two confirmation messages when deleting the last item of a document #1817

Closed
JoelleDosimont opened this issue Apr 9, 2021 · 0 comments · Fixed by rero/rero-ils-ui#582
Closed
Assignees
Labels
bug Breaks something but is not blocking f: professional ui Professional interface

Comments

@JoelleDosimont
Copy link
Contributor

Describe the bug
When deleting the last item of a record, there is 2 confirmation messages "Do you really want to delete this record?" and we need to refresh the page to activate the "Delete" button of the bibliographic record.

To Reproduce

  1. Go to a record with only one item
  2. Delete the last item
  3. See the 2 confirmation messages that follow each other (one for the item, one for the holding I guess). If you confirm the delete for the 2nd messages, it spins forever.
  4. See that the "Delete" button of the bibliographic record is not activate. You need to refresh the page.

Expected behavior
There should be only one confirmation message. The holding is deleted automatically if there is no more item attached.
The "delete" button should then be automatically activated (as there is no item attached).

Context

@JoelleDosimont JoelleDosimont added triage bug Breaks something but is not blocking labels Apr 9, 2021
@iGormilhit iGormilhit added f: professional ui Professional interface and removed triage labels Apr 27, 2021
@iGormilhit iGormilhit changed the title Delete the last item of a bibliographic record Two confirmation messages when deleting the last item of a document Apr 27, 2021
@zannkukai zannkukai self-assigned this Apr 30, 2021
zannkukai added a commit to zannkukai/rero-ils-ui that referenced this issue Apr 30, 2021
Closes rero/rero-ils#1817.

Co-Authored-By: Renaud Michotte <renaud.michotte@gmail.com>
zannkukai added a commit to rero/rero-ils-ui that referenced this issue May 7, 2021
Closes rero/rero-ils#1817.

Co-Authored-By: Renaud Michotte <renaud.michotte@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Breaks something but is not blocking f: professional ui Professional interface
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants