Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

It is impossible to create a circulation policy with overdue fees #1848

Closed
pronguen opened this issue Apr 25, 2021 · 0 comments · Fixed by #1850
Closed

It is impossible to create a circulation policy with overdue fees #1848

pronguen opened this issue Apr 25, 2021 · 0 comments · Fixed by #1850
Assignees
@zannkukai
Labels
bug Breaks something but is not blocking f: editor Concerns editor based on JSON schema AND custom editor p-High High priority (to be solved in the 2-3 next months)

Comments

@pronguen
Copy link
Contributor

Describe the bug

It is impossible to create a circulation policy with overdue fees. The editor does not allow to save the policy. If the field is removed, the policy can be saved.

To Reproduce

  1. Create a new circulation policy without overdue fees
  2. Save it
  3. Edit it and add overdue fees
  4. Try to save it

Expected behavior

It is possible to save it.

Context

Screenshots

image
@pronguen pronguen added f: editor Concerns editor based on JSON schema AND custom editor triage bug Breaks something but is not blocking p-High High priority (to be solved in the 2-3 next months) labels Apr 25, 2021
@iGormilhit iGormilhit removed the triage label Apr 27, 2021
@zannkukai zannkukai self-assigned this Apr 27, 2021
zannkukai added a commit to zannkukai/rero-ils that referenced this issue Apr 27, 2021
@zannkukai
Circulation category: limit fee 'from' day interval field
fbae7c2 
An incremental fee limit are define by thee fields : from, to and cost.
The 'from' field minimum value must be upper or equal to 1.
Closes rero#1848.

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
@zannkukai zannkukai mentioned this issue Apr 27, 2021
Merged
7 tasks
@zannkukai zannkukai modified the milestone: v1.3.0 Apr 27, 2021
zannkukai added a commit to zannkukai/rero-ils that referenced this issue Apr 30, 2021
@zannkukai
Circulation category: limit fee 'from' day interval field
621f50e 
An incremental fee limit are define by thee fields : from, to and cost.
The 'from' field minimum value must be upper or equal to 1.
Closes rero#1848.

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
zannkukai added a commit that referenced this issue May 4, 2021
@zannkukai
Circulation category: limit fee 'from' day interval field
1bbb940 
An incremental fee limit are define by thee fields : from, to and cost.
The 'from' field minimum value must be upper or equal to 1.
Closes #1848.

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
zannkukai added a commit that referenced this issue May 7, 2021
@zannkukai
Circulation category: limit fee 'from' day interval field
d23d1f4 
An incremental fee limit are define by thee fields : from, to and cost.
The 'from' field minimum value must be upper or equal to 1.
Closes #1848.

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zannkukai zannkukai

Labels
bug Breaks something but is not blocking f: editor Concerns editor based on JSON schema AND custom editor p-High High priority (to be solved in the 2-3 next months)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Circulation category: limit fee 'from' day interval field zannkukai/rero-ils
3 participants
@iGormilhit @pronguen @zannkukai