Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Impossible to save a document when created with a template #1926

Closed
pronguen opened this issue May 17, 2021 · 0 comments
Closed

Impossible to save a document when created with a template #1926

pronguen opened this issue May 17, 2021 · 0 comments
Labels
bug Breaks something but is not blocking f: editor Concerns editor based on JSON schema AND custom editor p-High High priority (to be solved in the 2-3 next months)

Comments

@pronguen
Copy link
Contributor

Describe the bug

The document form cannot be saved when it was opened with this specific template (it does not give any explanations to the end user, see screenshot): https://ils.test.rero.ch/professional/records/templates/detail/185

{"created":"2021-05-14T15:10:51.157549+00:00","id":"185","links":{"self":"https://ils.test.rero.ch/api/templates/185"},"metadata":{"$schema":"https://ils.rero.ch/schemas/templates/template-v0.0.1.json","creator":{"$ref":"https://ils.rero.ch/api/patrons/16"},"data":{"$schema":"https://ils.rero.ch/schemas/documents/document-v0.0.1.json","_masked":false,"adminMetadata":{"descriptionLanguage":"fre","encodingLevel":"Full level"},"contentMediaCarrier":[{"carrierType":"rdact:1049","contentType":["rdaco:1020"],"mediaType":"rdamt:1007"}],"contribution":[{"agent":{"date_of_birth":"19..-....","preferred_name":"Nom, pr\u00e9nom","type":"bf:Person"},"role":["aut"]}],"extent":"xxx pages","genreForm":[{"identifiedBy":{"type":"rero-rameau","value":"A021121540"},"source":"rero","term":"[Roman policier]","type":"bf:Topic"}],"identifiedBy":[{"type":"bf:Ean","value":"0000000000"}],"issuance":{"main_type":"rdami:1001","subtype":"materialUnit"},"language":[{"type":"bf:Language","value":"fre"}],"pid":"2019394","provisionActivity":[{"place":[{"country":"fr","type":"bf:Place"}],"startDate":2021,"statement":[{"label":[{"value":"[Lieu]"}],"type":"bf:Place"},{"label":[{"value":"nom de l'\u00e9diteur"}],"type":"bf:Agent"},{"label":[{"value":"[2021]"}],"type":"Date"}],"type":"bf:Publication"}],"responsibilityStatement":[[{"value":"mention de responsabilit\u00e9"}]],"seriesStatement":[{"seriesTitle":[{"value":"collection xxx"}]}],"title":[{"mainTitle":[{"value":"titre propre"}],"subtitle":[{"value":"sous-titre"}],"type":"bf:Title"}],"type":[{"main_type":"docmaintype_book","subtype":"docsubtype_other_book"}]},"name":"[CLT] mod\u00e8le formation livre roman policier","organisation":{"$ref":"https://ils.rero.ch/api/organisations/3"},"pid":"185","template_type":"documents","visibility":"public"},"updated":"2021-05-14T15:11:17.683668+00:00"}

With other templates, it works.

To Reproduce

  1. Log in as reroilstest+imagination@gmail.com (organisation 3)
  2. Use this template
  3. Fill the fields and try to save (impossible)
  4. Remove all fields except the required ones and try to save (impossible)

Expected behavior

  • It is possible to save a document using this template.
  • The form explains to the end user what the error is.

Context

Screenshots

image

@pronguen pronguen added f: editor Concerns editor based on JSON schema AND custom editor bug Breaks something but is not blocking p-High High priority (to be solved in the 2-3 next months) labels May 17, 2021
rerowep added a commit to rerowep/rero-ils that referenced this issue May 18, 2021
* Closes rero#1926.

Co-Authored-by: Peter Weber <peter.weber@rero.ch>
rerowep added a commit to rerowep/rero-ils that referenced this issue May 19, 2021
* Closes rero#1926.
* Adds the `date` part that is missing to the creation of the publication
  statement text (provision activity).

Co-Authored-by: Peter Weber <peter.weber@rero.ch>
rerowep added a commit to rerowep/rero-ils that referenced this issue May 19, 2021
* Closes rero#1926.
* Adds the `date` part that is missing to the creation of the publication
  statement text (provision activity).

Co-Authored-by: Peter Weber <peter.weber@rero.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Breaks something but is not blocking f: editor Concerns editor based on JSON schema AND custom editor p-High High priority (to be solved in the 2-3 next months)
Projects
None yet
Development

No branches or pull requests

1 participant