Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Item does not get the correct status after migrating Virtua loans #1974

Closed
BadrAly opened this issue Jun 3, 2021 · 1 comment · Fixed by #2016
Closed

Item does not get the correct status after migrating Virtua loans #1974

BadrAly opened this issue Jun 3, 2021 · 1 comment · Fixed by #2016
Assignees
@BadrAly
Labels
bug Breaks something but is not blocking f: circulation Concerns the circulation interface or backend f: data migration Data migration from a legacy system or a previous version
Milestone
v1.4.0

Comments

@BadrAly
Copy link

BadrAly commented Jun 3, 2021 •
edited
Loading

Item status remains on_shelf after creating ITEM_ON_LOAN loan for the item.

The method reroils_modules_loans_load_virtua_transactions is created to load loans from the Virtua database directly to the REROILS instance. Process works correctly however, the loaded loans do not update the item status.

After loading the loan, the new loan is well attached to the item. the on_shelf status remain unchanged.

  • server: [ilspilot.test.rero.ch]
  • version: v0.12.0

Screenshots

Screenshot 2021-06-03 at 15 19 57

Item is checked-out and status remains on_shelf.
@BadrAly BadrAly added triage bug Breaks something but is not blocking labels Jun 3, 2021
@BadrAly BadrAly changed the title Item status remains on_shelf after creating ITEM_ON_LOAN loan for the item Item does not get the correct status after migration Virtua loans Jun 3, 2021
@BadrAly BadrAly changed the title Item does not get the correct status after migration Virtua loans Item does not get the correct status after migrating Virtua loans Jun 3, 2021
@BadrAly BadrAly self-assigned this Jun 4, 2021
BadrAly pushed a commit to BadrAly/rero-ils that referenced this issue Jun 5, 2021
items: receive incorrect status after migrating Virtua loans
8e69a65 
Forces item status to on_loan for checked items.
Fixes rero#1974

Co-Authored-by: Aly Badr <aly.badr@rero.ch>
@BadrAly BadrAly mentioned this issue Jun 5, 2021
Closed
7 tasks
@iGormilhit iGormilhit added f: circulation Concerns the circulation interface or backend f: data migration Data migration from a legacy system or a previous version and removed triage labels Jun 7, 2021
@iGormilhit iGormilhit modified the milestones: v1.3.0, v1.4.0 Jun 7, 2021
@ManaDeweerdt
Copy link
Contributor

Same when we add a new item. Ex https://ils.test.rero.ch/professional/records/items/detail/4052
In this case, it should display the status label in place of 'on shelf'.

BadrAly pushed a commit to BadrAly/rero-ils that referenced this issue Jun 9, 2021
items: fix status according to migrated loans
9f0bddf 
Fixes problem when renewals of migrated loans was not possible.

* Fixes rero#1983
* Fixes rero#1974

Co-Authored-by: Aly Badr <aly.badr@rero.ch>
@BadrAly BadrAly mentioned this issue Jun 9, 2021
Merged
7 tasks
BadrAly pushed a commit to BadrAly/rero-ils that referenced this issue Jun 9, 2021
items: fix status according to migrated loans
bff990b 
Fixes problem when renewals of migrated loans was not possible.

* Fixes rero#1983
* Fixes rero#1974

Co-Authored-by: Aly Badr <aly.badr@rero.ch>
BadrAly pushed a commit to BadrAly/rero-ils that referenced this issue Jun 10, 2021
items: fix status according to migrated loans
c0d1b7f 
* Fixes problem when renewals of migrated loans was not possible.
* Fixes rero#1983
* Fixes rero#1974

Co-Authored-by: Aly Badr <aly.badr@rero.ch>
BadrAly pushed a commit that referenced this issue Jun 10, 2021
items: fix status according to migrated loans
d5ea3b6 
* Fixes problem when renewals of migrated loans was not possible.
* Fixes #1983
* Fixes #1974

Co-Authored-by: Aly Badr <aly.badr@rero.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BadrAly BadrAly

Labels
bug Breaks something but is not blocking f: circulation Concerns the circulation interface or backend f: data migration Data migration from a legacy system or a previous version
Projects
None yet
Milestone
v1.4.0
3 participants
@iGormilhit @ManaDeweerdt @BadrAly