Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The limit by overdue items is activated while the loans are not yet overdue #2014

Closed
pronguen opened this issue Jun 9, 2021 · 0 comments · Fixed by #2114
Closed

The limit by overdue items is activated while the loans are not yet overdue #2014

pronguen opened this issue Jun 9, 2021 · 0 comments · Fixed by #2114
Assignees
@zannkukai
Labels
bug Breaks something but is not blocking f: circulation Concerns the circulation interface or backend p-High High priority (to be solved in the 2-3 next months)
Milestone
v1.4.0

Comments

@pronguen
Copy link
Contributor

pronguen commented Jun 9, 2021 •
edited by iGormilhit
Loading

Describe the bug

The limit by overdue items on the item type is activated too early while the loans are not yet overdue.

To Reproduce

  1. Edit item type X
  2. Set a limit by overdue item to 3 and save
  3. Create 4 items with item type X
  4. Open the checkout form for a patron
  5. Select a fix date for the same day (if it is not possible, adapt the opening hours of the library so that it is open this day)
  6. Check out these 4 items (for the end of the current day)
  7. See that the 4th item cannot be checked out because of the limit

Expected behavior

The limit by overdue items is activated only when the loans are really overdue.

Context

Screenshots

Limit on patron type on overdue items (limits.overdue_items_limits) is set to 3, the 4th item cannot be checked out.
image

Same configuration, but only two of the 3 loans are for the current day, the 4th loan is allowed.
image
@pronguen pronguen added f: circulation Concerns the circulation interface or backend bug Breaks something but is not blocking p-Medium Medium priority (to be solved within 1-2 years) p-High High priority (to be solved in the 2-3 next months) and removed p-Medium Medium priority (to be solved within 1-2 years) labels Jun 9, 2021
@pronguen pronguen added this to the v1.4.0 milestone Jun 15, 2021
@zannkukai zannkukai self-assigned this Jul 2, 2021
zannkukai added a commit to zannkukai/rero-ils that referenced this issue Jul 2, 2021
@zannkukai
circulation: fix check is loan overdue method
8e8a29d 
Closes rero#2014.

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
@zannkukai zannkukai mentioned this issue Jul 2, 2021
Merged
7 tasks
zannkukai added a commit to zannkukai/rero-ils that referenced this issue Jul 2, 2021
@zannkukai
circulation: fix check is loan overdue method
09c9660 
Closes rero#2014.

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
zannkukai added a commit to zannkukai/rero-ils that referenced this issue Jul 2, 2021
@zannkukai
circulation: fix check is loan overdue method
73ca14d 
Closes rero#2014.

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
zannkukai added a commit to zannkukai/rero-ils that referenced this issue Jul 5, 2021
@zannkukai
circulation: fix method for "is loan overdue" check
fdd738f 
Closes rero#2014.

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
zannkukai added a commit to zannkukai/rero-ils that referenced this issue Jul 6, 2021
@zannkukai
circulation: fix method for "is loan overdue" check
b7e9f28 
Closes rero#2014.

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
zannkukai added a commit that referenced this issue Jul 7, 2021
@zannkukai
circulation: fix method for "is loan overdue" check
90cbf26 
Closes #2014.

Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
@iGormilhit iGormilhit changed the title The limit by overdue items is activated while the loans are not yet overdue. The limit by overdue items is activated while the loans are not yet overdue Jul 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zannkukai zannkukai

Labels
bug Breaks something but is not blocking f: circulation Concerns the circulation interface or backend p-High High priority (to be solved in the 2-3 next months)
Projects
None yet
Milestone
v1.4.0
Development

Successfully merging a pull request may close this issue.

circulation: fix method for "is loan overdue" check zannkukai/rero-ils
2 participants
@pronguen @zannkukai